Merge pull request #196 from narspt/patch-10

revert to closing streams immediately but fix last packets sent back

src/cprotocol.cpp

@@ -139,11 +139,11 @@ void CProtocol::OnDvFramePacketIn(CDvFramePacket *Frame, const CIp *Ip)
     // find the stream
     CPacketStream *stream = GetStream(Frame->GetStreamId(), Ip);
     if ( stream == NULL )
-	{
+    {
-		// std::cout << "Deleting oprhaned Last Frame Packet with StreamId " << Frame->GetStreamId() << " from " << *Ip << std::endl;
+        // std::cout << "Deleting oprhaned Frame Packet with StreamId " << Frame->GetStreamId() << " from " << *Ip << std::endl;
-		delete Frame;
+        delete Frame;
-	}
+    }
-	else
+    else
     {
         //std::cout << "DV frame" << "from "  << *Ip << std::endl;
         // and push
@@ -158,22 +158,40 @@ void CProtocol::OnDvLastFramePacketIn(CDvLastFramePacket *Frame, const CIp *Ip)
     // find the stream
     CPacketStream *stream = GetStream(Frame->GetStreamId(), Ip);
     if ( stream == NULL )
- 	{
+    {
-		// std::cout << "Deleting oprhaned Last Frame Packet with StreamId " << Frame->GetStreamId() << " from " << *Ip << std::endl;
+        // std::cout << "Deleting oprhaned Last Frame Packet with StreamId " << Frame->GetStreamId() << " from " << *Ip << std::endl;
-		delete Frame;
+        delete Frame;
-	}
+    }
-	else
+    else
     {
         // push
         stream->Lock();
         stream->Push(Frame);
         stream->Unlock();
 
-        // and don't close the stream yet but rely on CheckStreamsTimeout
+        // wait stream queue is empty, same as done in CloseStream(), but we need it before HandleQueue()
-        // mechanism, so the stream will be closed after the queues have
+        bool bEmpty = false;
-        // been sinked out. This avoid last packets to be send back
+        do
-        // to transmitting client (master)
+        {
-        // g_Reflector.CloseStream(stream);
+            stream->Lock();
+            // do not use stream->IsEmpty() has this "may" never succeed
+            // and anyway, the DvLastFramPacket short-circuit the transcoder
+            // loop queues
+            bEmpty = stream->empty();
+            stream->Unlock();
+            if ( !bEmpty )
+            {
+                // wait a bit
+                CTimePoint::TaskSleepFor(10);
+            }
+        } while (!bEmpty);
+
+        // handle queue from reflector a bit earlier, before closing the stream,
+        // this avoid last packets to be sent back to transmitting client (master)
+        HandleQueue();
+        
+        // and close the stream
+        g_Reflector.CloseStream(stream);
     }
 }