Relaxed flatness test and minus crash solved

Makefile

@@ -37,7 +37,7 @@ endif
 
 # Linker extra options here.
 ifeq ($(USE_LDOPT),)
-  USE_LDOPT =
+  USE_LDOPT = --print-memory-usage
 endif
 
 # Enable this if you want link time optimizations (LTO)

nanovna.h

@@ -50,6 +50,7 @@
 #define __SI4468__
 #define __ADF4351__
 #define __NEW_SWITCHES__
+// #define __SI5351__
 #endif
 #define __PE4302__
 //#define __SIMULATION__

sa_core.c

@@ -5327,7 +5327,7 @@ int validate_signal_within(int i, float margin)
     peakFreq = (markers[2].frequency + markers[1].frequency)/2;
     markers[0].frequency = peakFreq;
     markers[0].index = (markers[2].index + markers[1].index)/2;
-    if (flatness > 0.2) {
+    if (flatness > 0.3) {
       test_fail_cause[i] = "Flatness ";
       return TS_FAIL;
     }

si5351.c

@@ -19,37 +19,165 @@
  */
 #include "hal.h"
 #include "nanovna.h"
-#ifdef __VNA__
+#ifdef __SI5351__
 #include "si5351.h"
 
+inline int palReadLine(uint32_t line) {
+  return ( palReadPort(PAL_PORT(line)) & (1<<PAL_PAD(line)) )
+}
+
+    /*
+     * Software i2c bus
+     */
+#define I2C_DELAY     my_microsecond_delay(10);
+
+    static inline void scl_low(void) {
+      palClearLine(LINE_PB13);
+        I2C_DELAY;
+    }
+
+    static inline void scl_high(void) {
+      palSetLine(LINE_PB13);
+        I2C_DELAY;
+    }
+
+    static inline void sda_low(void) {
+      palClearLine(LINE_PB14);
+        I2C_DELAY;
+    }
+
+    static inline void sda_high(void) {
+      palSetLine(LINE_PB14);
+        I2C_DELAY;
+    }
+
+    static void i2c_begin(void) {
+        sda_low();
+        scl_low();
+    }
+
+    static void i2c_end(void) {
+        sda_low();
+        scl_high();
+        sda_high();
+    }
+
+    uint32_t i2c_recv(int bits) {
+        uint32_t ret = 0;
+//        soft_i2c_sda.set_mode(GPIO_MODE_INPUT, GPIO_CNF_INPUT_PULL_UPDOWN, HIGH); // Input pullup
+        while(bits--) {
+            scl_high();
+            ret<<= 1;
+            if (palReadLine(LINE_PB14)) ret|=1;
+            scl_low();
+        }
+//        soft_i2c_sda.set_mode(GPIO_MODE_OUTPUT_2_MHZ, GPIO_CNF_OUTPUT_PUSHPULL, LOW); // Output low
+        return ret;
+    }
+
+#define CLOCK_TICK      {scl_high(); scl_low();}
+#define DATA_OUT(bit)   {if (bit) sda_high(); else sda_low();}
+    static bool i2c_send(uint8_t data) {
+        // put data on bus
+        for (uint16_t mask = 0x80; mask; mask>>=1){
+            DATA_OUT(data&mask);
+            CLOCK_TICK; // clock tick
+        }
+        // Read answer bit
+        bool ret = i2c_recv(1);
+        // Stop transfer at error (no answer)
+        if (ret)
+            i2c_end();
+        return ret;
+    }
+
+    void i2c_init() {
+//        soft_i2c_clk.set_mode(GPIO_MODE_OUTPUT_2_MHZ, GPIO_CNF_OUTPUT_PUSHPULL);
+//        soft_i2c_sda.set_mode(GPIO_MODE_OUTPUT_2_MHZ, GPIO_CNF_OUTPUT_PUSHPULL);
+        i2c_begin();
+        i2c_end();
+    }
+
+    bool i2c_probe(uint8_t devAddr) {
+        i2c_begin();
+        // device address
+        if(i2c_send((devAddr<<1) | I2C_WRITE))
+            return false;
+        i2c_end();
+        return true;
+    }
+
+    // return value: 0: success; -1: no device ack; -2: no register addr ack; -3: no data ack
+    int i2c_write(uint8_t devAddr, uint8_t addr, uint8_t data) {
+        i2c_begin();
+        // device address
+        if(i2c_send((devAddr<<1) | I2C_WRITE))
+            return -1;
+        // register address
+        if(i2c_send(addr))
+            return -2;
+        // data
+        if(i2c_send(data))
+            return -3;
+        i2c_end();
+        return 0;
+    }
+
+    // return value: 0: success; -1: no device ack; -2: no register addr ack or data ack
+    int i2c_write_buf(uint8_t devAddr, uint8_t* data, int len) {
+        i2c_begin();
+        // device address
+        if(i2c_send((devAddr<<1) | I2C_WRITE))
+            return -1;
+        // data
+        for(int i=0; i<len; i++)
+            if(i2c_send(data[i]))
+                return -2;
+        i2c_end();
+        return 0;
+    }
+
+    // return value: >= 0: the read data; -1: no device ack; -2: no register addr ack
+    int i2c_read(uint8_t devAddr, uint8_t addr) {
+        i2c_begin();
+        // device address
+        if(i2c_send((devAddr<<1) | I2C_READ))
+            return -1;
+        // register address
+        if(i2c_send(addr))
+            return -2;
+        // data
+        int res = i2c_recv(8);
+        i2c_end();
+        return res;
+    }
+
+
+
 #define SI5351_I2C_ADDR   	(0x60<<1)
 
-static bool si5351_bulk_read(uint8_t reg, uint8_t* buf, int len)
+static bool si5351_read(uint8_t reg, uint8_t* buf)
 {
     int addr = SI5351_I2C_ADDR>>1;
-    i2cAcquireBus(&I2CD1);
+    int v = i2c_read(addr, reg);
-    msg_t mr = i2cMasterTransmitTimeout(&I2CD1, addr, &reg, 1, buf, len, 1000);
+    if (v < 0)
-    i2cReleaseBus(&I2CD1);
+      return false;
-    return mr == MSG_OK;
+    *buf = (uint8_t) v
+    return true;
 }
 
 static bool si5351_write(uint8_t reg, uint8_t dat)
 {
   int addr = SI5351_I2C_ADDR>>1;
-  uint8_t buf[] = { reg, dat };
+  int s = i2c_write(addr, reg, dat);
-  i2cAcquireBus(&I2CD1);
+  return s >= 0;
-  msg_t mr = i2cMasterTransmitTimeout(&I2CD1, addr, buf, 2, NULL, 0, 1000);
-  i2cReleaseBus(&I2CD1);
-  return mr == MSG_OK;
 }
 
 static bool si5351_bulk_write(const uint8_t *buf, int len)
 {
   int addr = SI5351_I2C_ADDR>>1;
-  i2cAcquireBus(&I2CD1);
+  int s = i2c_write_buf(addr, buf, len);
-  msg_t mr = i2cMasterTransmitTimeout(&I2CD1, addr, buf, len, NULL, 0, 1000);
+  return s > 0;
-  i2cReleaseBus(&I2CD1);
-  return mr == MSG_OK;
 }
 
 // register addr, length, data, ...
@@ -80,7 +208,7 @@ static bool si5351_wait_ready(void)
     systime_t end = start + MS2ST(1000);     // 1000 ms timeout
     while (chVTIsSystemTimeWithin(start, end))
     {
-        if(!si5351_bulk_read(0, &status, 1))
+        if(!si5351_read(0, &status))
             status = 0xff;  // comm timeout
         if ((status & 0x80) == 0) 
             return true;
@@ -93,14 +221,14 @@ static void si5351_wait_pll_lock(void)
 {
     systime_t start = chVTGetSystemTime();
     uint8_t status = 0xff;
-    if(!si5351_bulk_read(0, &status, 1))
+    if(!si5351_read(0, &status))
         status = 0xff;  // comm timeout
     if ((status & 0x60) == 0)
         return;
     systime_t end = start + MS2ST(100);     // 100 ms timeout
     while (chVTIsSystemTimeWithin(start, end))
     {
-        if(!si5351_bulk_read(0, &status, 1))
+        if(!si5351_read(0, &status))
             status = 0xff;  // comm timeout
         if ((status & 0x60) == 0)
             return;

ui.c

@@ -1843,7 +1843,7 @@ keypad_click(int key)
     // append period if there are no period
     if (kp_index == j)
       kp_buf[kp_index++] = '.';
-  } else if (c == KP_MINUS) {
+  } else if (c == KP_MINUS && kp_index < NUMINPUT_LEN) {
     if (kp_index == 0)
       kp_buf[kp_index++] = '-';
     else {