meshcore-client

Commit Graph

Author	SHA1	Message	Date
diffwireauto	d2e9358f4d	fix(#910 ): four defects from the pre-PR review 1. The export shipped only the active log, and FileLogWriter._rotated was private, so offband.1.log and .2.log were unreachable by anything. An exit-record pointer line written at startup rotates out after a couple of MiB of ordinary logging, handing over a trace file with its metadata gone. FileLogWriter now exposes the files that exist, keeping the rotation naming where it belongs, and the mobile export attaches all of them. 2. dispose() called ioExecutor.shutdownNow() while a read could be holding a MethodChannel.Result. Interrupting it left the Result neither succeeded nor errored, so the Dart future never completed. Now shutdown(), with a disposed flag and a RejectedExecutionException path that always replies. 3. The trace read was skipped for REASON_CRASH_NATIVE on the assumption that its stream is always a protobuf. AOSP says a trace from an earlier ANR stays attached even when the process later died for another reason, so gating on the reason loses real text traces. The read is now attempted on every record and a printable-bytes check decides whether the content is usable. 4. The test-only main-thread block used a single Thread.sleep, which an interrupt could cut short: no ANR, no record, and a wasted trip to the hardware. It now sleeps to a deadline and ignores interrupts, which guarantees the duration without a busy-wait's CPU burn. Review also flagged that FileLogWriter can exceed maxBytes for a single oversized entry. That is pre-existing writer semantics, already pinned by a test in this branch, and deliberately not changed here. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	3 weeks ago
diffwireauto	0a08ef7b06	test(#910 ): exit-record selection, formatting, pruning and rotation 43 tests. Selection covers the dedup contract: strictly-newer only, a record equal to the watermark treated as already logged, two records in one millisecond both kept, the watermark taking the highest rather than the first, and the backfill trace cap. Formatting covers the cases that would otherwise read wrong: zero pss and rss render as unknown rather than as a real measurement, a null description is omitted rather than printed, an absent trace records why, and a backfilled record says so. Every message the service can surface is asserted present for its own failure, and an ideal line is asserted to carry none of the failure markers. The channel layer runs behind a mock handler, which proves the watermark advances on success, does not move on a query failure so the next launch retries, and that collect never throws and runs once per launch. What these cannot prove, stated in the test file header: that Android actually produces a REASON_ANR record with a readable trace. That needs a real main-thread block on an API 30+ device and a relaunch, which is #911 part B. The rotation tests pin down what a 40 KB entry actually does, which is the Epic's rotation criterion: it rotates once and is written whole, the active file is then legitimately above maxBytes because that gate decides when to rotate rather than truncating, and maxFiles still holds so the log cannot grow without bound. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	3 weeks ago
Strycher	0047ee0c8c	feat(#574 ): stock config export screen Mirrors stock's Export Config screen: section list, Select All and Deselect All, everything checked by default. The asymmetry with import, which will start with nothing checked, is stock's own and is deliberate: opt out on the way out, opt in on the way in. A section the user ticked that could not be gathered is shown before the file is written, with its specific reason, and the user chooses whether to export anyway. Firmware-built-without-it reads differently from device-did-not-answer because only one of them is worth retrying. The screen also states plainly that this is the stock format and cannot carry Offband-only data, so importing the file back will not restore it. File naming follows stock, <name>_meshcore_config_<stamp>.json, and is sanitized for the filesystem without touching the name written inside the file, which has to round-trip exactly. Real device names in the reference corpus contain emoji and a trailing space, both covered by tests. Writing reuses LogExport for the per-platform mechanism (share sheet on mobile, Save As on desktop, download on web) rather than adding a second export path that could drift. The temp file can contain the node private key, so it is written under the app's own temp directory. The public key is abbreviated on screen; the private key is never rendered. 6 tests on the file name.	2 months ago
Strycher	3b39a16edd	chore(#462 ): remove em-dash characters from test/ (and lib top-up) Follow-up to #457. Swept the em-dash character (U+2014) out of the test tree (test descriptions and comments) and cleaned 8 em-dashes that landed in lib comments via the #456 refactor after #457 merged, so the tree is back to zero. Same rules: replaced with commas/colons/periods, preserved the lone "no data" glyph placeholders, left non-English ARB untouched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	4 months ago
Strycher	ea4adb3faa	fix(#248 ): VID-gate the USB DTR open pulse (don't wedge ESP32-C6) The DTR low→high pulse in the desktop USB open path resets ESP32 USB-Serial/JTAG chips (VID 303A: C6/H2/S3-HWCDC) into ROM download mode mid-handshake, wedging the device until a physical reset. The pulse exists for nRF52 (VID 239A) reconnect-after-unclean-disconnect, so it can't just be removed. connect() now recovers the port's USB VID from the flserial enumeration (hardware_id) and gates the pulse: 239A keeps the DTR low→high pulse; 303A and any unknown/unparseable VID open with DTR asserted and no pulse. VID lookup is enumeration-only (never opens the port). New usb_vid helper parses both flserial hardware_id formats (Windows VID_XXXX and macOS/Linux VID:PID=xxxx:xxxx), unit tested. Build of epic #245.	4 months ago
Strycher	1fa0b53d57	feat(#97 ): mirror app/BLE logs to rotating files on disk (cross-platform) Always-on file logging so users/support can retrieve a log without enabling anything in the UI. No-op on web (no filesystem). - FileLogWriter: rotating file writer (size cap + max files), single + batch writes, unit-tested against a real temp dir. - FileLogService: singleton initialised in main(); resolves getApplicationSupportDirectory()/logs, queues lines, periodic 2s batched flush, bounded queue, never crashes the app on an IO error. - AppDebugLogService.log + BleDebugLogService.logFrame write every entry to the file (app logs always, independent of the in-app viewer's enable gate). Location per the #97 decision: standard support dir on all platforms (Windows %APPDATA%\app.offband.meshcore\logs). Still TODO before recompile: access UI ("Open logs folder" on desktop / "Share logs" on mobile). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	5 months ago
just-stuff-tm	3452bdae8c	Refactor test cases for USB flow and port labels for improved readability	8 months ago
just-stuff-tm	25fc9454a8	Add error handling tests for USB connection and listing ports	8 months ago
Ben Allfree	e6c9a3fea7	wip	8 months ago
just_stuff_tm	f39a22668e	Add initial load scheduling and tests for USB screen and frame codec functionality	8 months ago
just_stuff_tm	c23a1da430	Add web serial support and USB tests	8 months ago
just_stuff_tm	061b715694	Fix repeater battery % inconsistency and add configurable repeater battery chemistry (#199 ) * fix(repeater): unify battery percentage math and add repeater chemistry setting - Add shared battery percent utility used by connector, repeater status, and telemetry - Add repeater-specific battery chemistry persistence and service accessors - Add repeater chemistry selector in Repeater Hub - Ensure telemetry and status compute percentages consistently from same chemistry - Add focused battery utility tests Refs #116 Refs #174 * fix: Flutter Analyzer Errors fixed Recent Merge Compatible * Unify repeater battery source across status and telemetry	9 months ago

12 Commits (ee01c1917526eeec8c511693179a87c314387bec)