fix(#298): log path units truthfully instead of asserting wrong hop counts
The original diagnostic derived hops via realHopCount(), which divides a value that firmware already defines as a hop count (src/Packet.h:79-84: getPathByteLen() == getPathHashCount() * getPathHashSize()). It would have reported hops=1 for a real 2-hop path, misleading the exact investigation this logging exists to serve. _pathDiag now reports the hop count directly and prints held-vs-implied byte counts, flagging TRUNCATED when short. That makes the #309 decode truncation self-evident in any capture without the device present. The login dialogs no longer assert a hop count at all: selection.hopCount is ambiguous by construction (device paths carry hops, user overrides carry bytes, per #279), so they log the raw field, width and actual byte length, which discriminates the two cases. Refs #240, #279, #309 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>chore/298-path-logging
parent
2cab69606b
commit
eb3094e149
Loading…
Reference in new issue