add some more validation

APRSFrame.cpp

@@ -41,5 +41,6 @@ void CAPRSFrame::clear()
     m_source.clear();
     m_destination.clear();
     m_path.clear();
+    m_body.clear();
     m_type = APFT_UNKNOWN;
 }

APRSParser.cpp

@@ -67,7 +67,8 @@ void CAPRSParser::setFrameType(CAPRSFrame& frame)
         switch (body[0])
         {
             case ':':
-                if(body[10] == ':')
+                if(body[10] == ':' && std::all_of(body.begin() + 1, body.begin() + 10,
+                                                [](char c){ return c == ' ' || c == '-' || (c >= 'A' && c <= 'Z') || (c >= '0' && c <= '9'); }))
                     type = APFT_MESSAGE;
                 break;
             

Tests/APRSParser/parseAPRSFrame.cpp

@@ -90,3 +90,16 @@ TEST_F(APRSParser_parseAPRSFrame, CorrectMessageFrameWithoutDigipeater) {
     EXPECT_EQ(aprsFrame.getType(), APFT_MESSAGE);
     EXPECT_EQ(aprsFrame.getPath().size(), 0);
 }
+
+TEST_F(APRSParser_parseAPRSFrame, InvalideMessageFrame) {
+
+    CAPRSFrame aprsFrame;
+    bool retVal = CAPRSParser::parseFrame("N0CALL>APRS::F4ABC&@#$:Test Message", aprsFrame);
+
+    EXPECT_FALSE(retVal);
+    EXPECT_STRCASEEQ(aprsFrame.getBody().c_str(), "");
+    EXPECT_STRCASEEQ(aprsFrame.getDestination().c_str(), "");
+    EXPECT_STRCASEEQ(aprsFrame.getSource().c_str(), "");
+    EXPECT_EQ(aprsFrame.getType(), APFT_UNKNOWN);
+    EXPECT_EQ(aprsFrame.getPath().size(), 0U);
+}