do not reset nakFallOverCount ever, this is a fatal accumulation, if we accumulate NAKs then are suddenly fine, this can cause a situation where the NAK fallover logic never activates;

6 days ago · 5a0ae176c3
parent 6fca7c8d99
commit 5a0ae176c3
1 changed files with 0 additions and 9 deletions
--- a/src/fne/network/PeerNetwork.cpp
+++ b/src/fne/network/PeerNetwork.cpp
@ -327,9 +327,6 @@ void PeerNetwork::userPacketHandler(uint32_t peerId, FrameQueue::OpcodePair opco
                if (m_peerReplicaCallback != nullptr)
                    m_peerReplicaCallback(this);

-                // reset NAK count on reception of a replica TG
-                m_nakFallOverCount = 0U;
-
                // cleanup temporary file
                ::remove(filename.c_str());
                m_tgidPkt.clear();
@ -389,9 +386,6 @@ void PeerNetwork::userPacketHandler(uint32_t peerId, FrameQueue::OpcodePair opco
                if (m_peerReplicaCallback != nullptr)
                    m_peerReplicaCallback(this);

-                // reset NAK count on reception of a replica TG
-                m_nakFallOverCount = 0U;
-
                // cleanup temporary file
                ::remove(filename.c_str());
                m_ridPkt.clear();
@ -451,9 +445,6 @@ void PeerNetwork::userPacketHandler(uint32_t peerId, FrameQueue::OpcodePair opco
                if (m_peerReplicaCallback != nullptr)
                    m_peerReplicaCallback(this);

-                // reset NAK count on reception of a replica TG
-                m_nakFallOverCount = 0U;
-
                // cleanup temporary file
                ::remove(filename.c_str());
                m_pidPkt.clear();