From 38984be6bb1e4a53928cbf9bc4553e197c79757a Mon Sep 17 00:00:00 2001
From: Tom Early <ham.n7tae@gmail.com>
Date: Wed, 8 May 2024 16:41:07 -0700
Subject: [PATCH] add select to Accept

---
 reflector/CodecStream.cpp | 10 ++++++----
 reflector/TCSocket.cpp    | 32 ++++++++++++++++++++++++++++----
 2 files changed, 34 insertions(+), 8 deletions(-)

diff --git a/reflector/CodecStream.cpp b/reflector/CodecStream.cpp
index bde8508..2a436e2 100644
--- a/reflector/CodecStream.cpp
+++ b/reflector/CodecStream.cpp
@@ -110,17 +110,19 @@ void CCodecStream::Thread()
 void CCodecStream::Task(void)
 {
 	int fd = g_TCServer.GetFD(m_CSModule);
+
+	// if the fd is not good we need to reestablish it
 	if (fd < 0) // log the situation
-		std::cout << "Lost connection to transcoder, module '" << m_CSModule << "', waiting..." << std::endl;
+		std::cout << "Lost connection to transcoder, module '" << m_CSModule << "', waiting for new connection..." << std::endl;
 	while (fd < 0)
 	{
-		if (g_TCServer.Accept()) // we will block until we have a new connection
+		if (g_TCServer.Accept()) // try to get a connection
 		{
 			std::cerr << "UNRECOVERABLE ERROR!" << std::endl;
 			exit(1);
 		}
-		// Accept was sucessful, but we need to make sure THIS MODULE was reestablished
-		// It's possile that other Transcoder ports were lost
+		// Either Accept timed out, or it's possile that other Transcoder ports were instead reopened
+		// So we'll check to see if the one for this module is okay now
 		fd = g_TCServer.GetFD(m_CSModule);
 	}
 
diff --git a/reflector/TCSocket.cpp b/reflector/TCSocket.cpp
index 710e356..03cab1a 100644
--- a/reflector/TCSocket.cpp
+++ b/reflector/TCSocket.cpp
@@ -20,6 +20,7 @@
 #include <chrono>
 #include <sys/types.h>
 #include <sys/socket.h>
+#include <sys/select.h>
 
 #include "IP.h"
 #include "TCSocket.h"
@@ -159,7 +160,7 @@ bool CTCServer::Open(const std::string &address, const std::string &modules, uin
 	}
 
 	auto n = m_Modules.size();
-	std::cout << "Waiting for " << n << " tC connection(s)..." << std::endl;
+	std::cout << "Waiting for " << n << " transcoder connection(s)..." << std::endl;
 
 	while (m_FD.size() < n)
 	{
@@ -174,6 +175,29 @@ bool CTCServer::Open(const std::string &address, const std::string &modules, uin
 
 bool CTCServer::Accept()
 {
+	struct timeval tv;
+    fd_set readfds;
+
+	// 10 milliseconds
+    tv.tv_sec = 0;
+    tv.tv_usec = 10000;
+
+    FD_ZERO(&readfds);
+    FD_SET(m_listenSock, &readfds);
+
+    // don't care about writefds and exceptfds:
+    int rv = select(m_listenSock+1, &readfds, NULL, NULL, &tv);
+	if (rv < 0)
+	{
+		perror("Accept select");
+		return true;
+	}
+
+	if (0 == rv)	// we timed out waiting for something
+		return false;
+
+	// here comes a connect
+
 	CIp their_addr; // connector's address information
 
 	socklen_t sin_size = sizeof(struct sockaddr_storage);
@@ -183,16 +207,16 @@ bool CTCServer::Accept()
 	{
 		if (EAGAIN == errno || EWOULDBLOCK == errno)
 			return false;
-		perror("accept");
+		perror("Accept accept");
 		return true;
 	}
 
 	char mod;
-	auto rv = recv(newfd, &mod, 1, 0);	// retrieve the identification byte
+	rv = recv(newfd, &mod, 1, 0);	// retrieve the identification byte
 	if (rv != 1)
 	{
 		if (rv < 0)
-			perror("accept recv");
+			perror("Accept recv");
 		else
 			std::cerr << "recv got no identification byte!" << std::endl;
 		close(newfd);