From eb58236e1d333538ab5123aaf0e1773d71f19431 Mon Sep 17 00:00:00 2001
From: accius <chris@cjhlighting.com>
Date: Mon, 2 Feb 2026 13:17:18 -0500
Subject: [PATCH] silencing non errors and fixing logging

---
 .env.example | 14 ++++++++------
 server.js    | 30 ++++++++++++++++++++++--------
 2 files changed, 30 insertions(+), 14 deletions(-)

diff --git a/.env.example b/.env.example
index 5c67c23..0d05b11 100644
--- a/.env.example
+++ b/.env.example
@@ -16,8 +16,8 @@ CALLSIGN=N0CALL
 LOCATOR=FN31
 
 # Your station coordinates (optional - calculated from LOCATOR if not set)
-LATITUDE=
-LONGITUDE=
+# LATITUDE=40.7128
+# LONGITUDE=-74.0060
 
 # ===========================================
 # SERVER SETTINGS
@@ -53,14 +53,16 @@ LAYOUT=modern
 # ===========================================
 
 # ITURHFProp service URL (for advanced propagation predictions)
-ITURHFPROP_URL=
+# Only uncomment if you have your own ITURHFProp service running
+# ITURHFPROP_URL=https://your-iturhfprop-service.com
 
 # DX Spider Proxy URL (for DX cluster spots)
-DXSPIDER_PROXY_URL=
+# Only uncomment if you have your own proxy running
+# DXSPIDER_PROXY_URL=https://your-dxspider-proxy.com
 
 # OpenWeatherMap API key (for local weather display)
 # Get a free key at https://openweathermap.org/api
-OPENWEATHER_API_KEY=
+# OPENWEATHER_API_KEY=your_api_key_here
 
 # ===========================================
 # FEATURE TOGGLES
@@ -80,7 +82,7 @@ SHOW_DX_PATHS=true
 # ===========================================
 
 # Your callsign for DX cluster login (default: CALLSIGN-56)
-DX_CLUSTER_CALLSIGN=
+# DX_CLUSTER_CALLSIGN=N0CALL-56
 
 # Spot retention time in minutes (5-30)
 SPOT_RETENTION_MINUTES=30
diff --git a/server.js b/server.js
index e6773a2..a531118 100644
--- a/server.js
+++ b/server.js
@@ -156,7 +156,10 @@ if (configMissing) {
 }
 
 // ITURHFProp service URL (optional - enables hybrid mode)
-const ITURHFPROP_URL = process.env.ITURHFPROP_URL || null;
+// Must be a full URL like https://iturhfprop.example.com
+const ITURHFPROP_URL = process.env.ITURHFPROP_URL && process.env.ITURHFPROP_URL.trim().startsWith('http') 
+  ? process.env.ITURHFPROP_URL.trim() 
+  : null;
 
 // Log configuration
 console.log(`[Config] Station: ${CONFIG.callsign} @ ${CONFIG.gridSquare || 'No grid'}`);
@@ -1780,17 +1783,16 @@ let tleCache = { data: null, timestamp: 0 };
 const TLE_CACHE_DURATION = 6 * 60 * 60 * 1000; // 6 hours
 
 app.get('/api/satellites/tle', async (req, res) => {
-  console.log('[Satellites] Fetching TLE data...');
-  
   try {
     const now = Date.now();
     
     // Return cached data if fresh
     if (tleCache.data && (now - tleCache.timestamp) < TLE_CACHE_DURATION) {
-      console.log('[Satellites] Returning cached TLE data');
       return res.json(tleCache.data);
     }
     
+    console.log('[Satellites] Fetching fresh TLE data...');
+    
     // Fetch fresh TLE data from CelesTrak
     const tleData = {};
     
@@ -1829,7 +1831,6 @@ app.get('/api/satellites/tle', async (req, res) => {
                 tle1: line1,
                 tle2: line2
               };
-              console.log('[Satellites] Found TLE for:', key, noradId);
             }
           }
         }
@@ -1839,10 +1840,18 @@ app.get('/api/satellites/tle', async (req, res) => {
     // Also try to get ISS specifically (it's in the stations group)
     if (!tleData['ISS']) {
       try {
+        const issController = new AbortController();
+        const issTimeout = setTimeout(() => issController.abort(), 10000);
+        
         const issResponse = await fetch(
           'https://celestrak.org/NORAD/elements/gp.php?CATNR=25544&FORMAT=tle',
-          { headers: { 'User-Agent': 'OpenHamClock/3.3' } }
+          { 
+            headers: { 'User-Agent': 'OpenHamClock/3.3' },
+            signal: issController.signal
+          }
         );
+        clearTimeout(issTimeout);
+        
         if (issResponse.ok) {
           const issText = await issResponse.text();
           const issLines = issText.trim().split('\n');
@@ -1856,7 +1865,9 @@ app.get('/api/satellites/tle', async (req, res) => {
           }
         }
       } catch (e) {
-        console.log('[Satellites] Could not fetch ISS TLE:', e.message);
+        if (e.name !== 'AbortError') {
+          logErrorOnce('Satellites', `ISS TLE fetch: ${e.message}`);
+        }
       }
     }
     
@@ -1867,7 +1878,10 @@ app.get('/api/satellites/tle', async (req, res) => {
     res.json(tleData);
     
   } catch (error) {
-    console.error('[Satellites] TLE fetch error:', error.message);
+    // Don't spam logs for timeouts (AbortError) or network issues
+    if (error.name !== 'AbortError') {
+      logErrorOnce('Satellites', `TLE fetch error: ${error.message}`);
+    }
     // Return cached data even if stale, or empty object
     res.json(tleCache.data || {});
   }