meshcore-client

History

diffwireauto bd0744e472 fix(#1060 ): drop erased records on load, and pace the restore writes Adversarial review (gemini-2.5-pro) on the push candidate raised five findings. Two were real and are fixed here; the other three are justified in the PR body. Storage is an untrusted source too. The guards already on this branch stop an erased (all-0xFF) record being adopted from the WIRE, but a build from before they existed could have persisted one, and loadCachedChannels applied no filter. _cachedChannels is a fallback identity source for _findChannelByIndex and is re-saved by the unread paths, so such a record comes back as the channel for live traffic and outlives every radio. It is dropped at the load boundary, which protects every consumer at once. It carries nothing recoverable: the name is U+FFFD and the PSK is all-ones. restoreChannelsToRadio sent its writes in an unpaced loop. On BLE sendFrame prefers write-without-response, so its await returns when the frame reaches the OS and not when the radio has taken it: a multi-channel restore could overrun the radio and lose channels with no error raised anywhere. The USB branch of sendFrame already spaces its own frames for exactly this reason. Same 10ms gap between consecutive channel writes. The restore result is documented as written and NOT confirmed. Counting confirmations after the re-sync was tried and reverted: getChannels returns once the first request is away rather than once the sync has finished, so it would have read a list the radio had not answered for and reported zero every time. The erased-slot banner is re-derived on every sync and stays up if writes did not land, so it remains the authoritative signal. Both new guards proved against planted defects rather than assumed: removing the load filter turns 2 tests red, and removing the pacing yields "Expected: a value greater than or equal to <20>, Actual: <0>". flutter analyze clean, 1896 tests pass, 1 skipped. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>		7 days ago
..
connector	fix(#1060 ): drop erased records on load, and pace the restore writes	7 days ago
helpers	epic(#868 ): companion CLI codec, service, console + entry (F2/E2.1) (#903 )	4 weeks ago
icons	ran dart format . on libs/icons/los_icon.dart	9 months ago
l10n	fix(#1060 ): drop erased records on load, and pace the restore writes	7 days ago
models	fix(#1060 ): erased slots never overwrite the channel list, and radio notify follows the channel	1 week ago
screens	Merge remote-tracking branch 'origin/dev' into feat/1068-radio-channel-notify	1 week ago
services	fix(#1065 ): drop the observer-config version gate too, bit only	1 week ago
storage	fix(#1063 ): keep per-slot message state from crossing channel identities	1 week ago
theme	chore(#457 ): remove em-dash characters from source	4 months ago
utils	feat(#1030 ): reach Share logs and About from the connect screen	2 weeks ago
widgets	fix(#1060 ): erased slots never overwrite the channel list, and radio notify follows the channel	1 week ago
main.dart	feat(#965 ): per-key migration timestamps and the stale-blob sweep	3 weeks ago