You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Strycher a57ec8f902 fix(#501): apply Gemini review, de-duplicate suppression logging ... Three findings reviewed, two applied, one rejected on evidence. APPLIED. Suppression logging is de-duplicated. Device-info arrives on every connect, so a flapping radio would have emitted the same suppression line on each reconnect. It now logs once per distinct reason, and the memo clears when a gate opens or when per-radio state is cleared, so the next genuine suppression is still reported. Real, and exactly the flooding the project forbids. APPLIED, though not reachable today. The scope reply logged reply.scope!, which is safe only because parseNotifyScopeReply returns an ERROR reply when the scope code is unknown, so a non-error reply always carries a scope. That invariant lives in another file, so it is now checked at the boundary instead of asserted with a bang across it. The review rated this High on the theory that an unknown sub-code could reach the handler; it cannot, because the parser returns null for any sub-code it does not own and the dispatcher only forwards what it returned. Defect not reachable, guard still worth having. REJECTED. The review claimed the matrix reply log is unbounded because the wire count byte allows up to 255 rows, estimating 7.5 KB per line. The log is built from ButtonMatrix.assignments, a Map keyed by ButtonSequence, which has exactly four values, and the parser skips sequence codes it does not recognise rather than adding them. The map therefore holds at most four entries and the line is bounded at roughly 160 characters no matter what the device sends. The count byte cannot inflate it. Full suite 740 pass, analyze clean, format clean. Agent: CalmBay (session d14220d9)		2 months ago
..
connector	fix(#501): apply Gemini review, de-duplicate suppression logging	2 months ago
helpers	feat(#550): monotonic channel-send timestamp + CoreScope message fields	2 months ago
icons	ran dart format . on libs/icons/los_icon.dart	7 months ago
l10n	fix(#528): apply the three accepted Gemini review findings	2 months ago
models	feat(#550): show observers + observations; top-banner refresh feedback	2 months ago
screens	fix(#528): apply the three accepted Gemini review findings	2 months ago
services	fix(#528): apply the three accepted Gemini review findings	2 months ago
storage	fix(#505, #506): per-radio block storage, drop the accidental global list	2 months ago
theme	chore(#457): remove em-dash characters from source	2 months ago
utils	chore(#457): remove em-dash characters from source	2 months ago
widgets	fix(#497): apply Gemini review, one honest label and one equivalence rule	2 months ago
main.dart	chore(#457): remove em-dash characters from source	2 months ago