meshcore-client

History

diffwireauto 3364895a9f feat(#523 ): display mode, status LED and rotation over 0xC5 0x1A/0x1B Lands the #523 indicator controls, separated from the factory reset (#1057) that happened to share their branch. #1057 is destructive, untested and the owner did not ask for it, so it stays behind rather than riding along. Rotation is 0xC5 0x1A GET / 0x1B SET, gated on TAG_DISPLAY_ROTATION in the 0x1C advert, with no caps-bit fallback and no probing. It is NOT 0x18/0x19: those are per-channel channel notify, and an earlier build that put rotation there corrupted silently, because the firmware's 0x19 handler validates a channel-notify mode and nothing else. The hazard commit 89f1768e is not in this history at all; this is the post-fix state only. Display mode and the status LED read device-info bytes 86 and 85. Nothing reads byte 87, which contract section 2 retired permanently. Provenance, since the route matters: cherry-picked ea09d2f3 with -m 1. That commit is the merge of the #523 work into the #1095 advert work, and the rotation fix lives in its merge resolution rather than in a commit of its own, so its first-parent diff is exactly what #523 adds on top of what dev already carries. The result is 956 insertions across 28 files, matching ea09d2f3's own stat, and offband_indicators.dart, indicators_view.dart and indicators_connector_test.dart are byte-identical to the old branch tip. Adversarial review (gemini-2.5-pro) found a crash, fixed here: the rotation control force-unwrapped displayRotation, but the advert tag that ENABLES the control arrives before the rotation GET reply that supplies the value, so the pane threw on any slow link. It now takes an empty selection, matching the display-mode control beside it, which was already null-safe. Proved by probe: restoring the unwrap yields "Null check operator used on a null value" and turns 2 of the new widget tests red. The review's second finding, a read reply overwriting a newer confirmed write, is real but deliberately NOT fixed here. The obvious guard is to drop read replies while a write is outstanding, and _sendIndicatorSet sets that flag with no timeout and no cleanup, unlike _awaitDeviceUi which clears it in a finally. That guard would wedge rotation reads for the rest of the session after any SET that went unanswered, which is worse than the stale value it prevents. Giving _sendIndicatorSet the same timeout discipline is the real fix and is follow-up work, not something to change minutes before a cut. flutter analyze clean, 1945 tests pass and 1 skipped, including 25 indicators connector tests and 4 new widget tests. Not hardware-tested. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>		6 days ago
..
about_view.dart	feat(#1051 ): hide Donate and the Experimental section on iOS	2 weeks ago
app_only_settings_screen.dart	feat(#1030 ): reach Share logs and About from the connect screen	2 weeks ago
app_settings_view.dart	feat(#966 ): Clear Stale History Now, with refusals reported	3 weeks ago
badge_battery_view.dart	feat(#986 , #970 , #971 , #987 ): badge tones and screen settings parity over 0xC5	3 weeks ago
badge_screen_view.dart	feat(#986 , #970 , #971 , #987 ): badge tones and screen settings parity over 0xC5	3 weeks ago
blocked_view.dart	epic(#938 ): Blocked pane says "no radio" instead of "no blocked users"	3 weeks ago
broker_editor_screen.dart	feat(#638 ): move notifications from bottom SnackBar to a top toast	2 months ago
config_profile_import_screen.dart	feat(#407 ): wire config-profile import into Observer settings	4 months ago
config_profile_preview_screen.dart	feat(#638 ): move notifications from bottom SnackBar to a top toast	2 months ago
debug_logs_view.dart	feat(#1030 ): reach Share logs and About from the connect screen	2 weeks ago
device_ui_view.dart	feat(#523 ): display mode, status LED and rotation over 0xC5 0x1A/0x1B	6 days ago
indicators_view.dart	feat(#523 ): display mode, status LED and rotation over 0xC5 0x1A/0x1B	6 days ago
location_view.dart	feat(#969 ): GPS mode and Power-save interval over 0xC5	3 weeks ago
message_settings_view.dart	feat(#978 ): split Button and buzzer into Node Settings and Message Settings	3 weeks ago
mqtt_brokers_screen.dart	chore(#457 ): remove em-dash characters from source	4 months ago
observer_settings_view.dart	feat(#638 ): move notifications from bottom SnackBar to a top toast	2 months ago
settings_shell.dart	chore(#457 ): remove em-dash characters from source	4 months ago
tune_slot_editor_screen.dart	fix(#970 ): act on the adversarial review, cite the merged firmware	3 weeks ago