meshcore-client

History

Strycher ded010a52f fix(#575 ): apply pre-PR review, stop claiming unconfirmed import success Adversarial review raised three findings. Two survived verification. Rejected: a claimed RangeError when abbreviating a short public key. The code already guards with a length check before either substring, so the crash it describes cannot occur. Rejected as described, fixed as found: contact position (0, 0) was said to be dropped on import. It is not. The frame builder writes the position block whenever lastModified is present, which it always is here, so a suppressed position still writes 0/0 and the bytes are identical either way. The hasPosition conditional was therefore doing nothing except misleading a reader, which is exactly what happened. Removed, and the behavior is pinned with a test. Accepted: the service added sections to 'applied' after sendFrame returned, which only means the frame left our side. A lost or refused frame was indistinguishable from success, so the user could be told an import worked when nothing changed on the device. A correct fix needs an awaited per-command acknowledgement in the connector, keyed on command code so concurrent commands cannot steal each other's OK. That is real connector work and is filed as #584. What is fixed here is the overclaim: 'applied' and the two counts are documented as sent rather than confirmed, and the result string now reads 'Sent N contacts and M channels to the device'. The code no longer states something it cannot know.		3 months ago
..
connector	feat(#573 ): stock config export service	3 months ago
helpers	feat(#550 ): monotonic channel-send timestamp + CoreScope message fields	3 months ago
icons	ran dart format . on libs/icons/los_icon.dart	9 months ago
l10n	fix(#575 ): apply pre-PR review, stop claiming unconfirmed import success	3 months ago
models	feat(#572 ): stock config format model + parser/serializer	3 months ago
screens	feat(#576 ): stock config import screen, and wire both into Settings	3 months ago
services	fix(#575 ): apply pre-PR review, stop claiming unconfirmed import success	3 months ago
storage	fix(#505 , #506 ): per-radio block storage, drop the accidental global list	3 months ago
theme	chore(#457 ): remove em-dash characters from source	4 months ago
utils	feat(#574 ): stock config export screen	3 months ago
widgets	fix(#497 ): apply Gemini review, one honest label and one equivalence rule	3 months ago
main.dart	chore(#457 ): remove em-dash characters from source	4 months ago