8 Commits (b96f20140f64b71071f68d0deb71fab486691810)

Author	SHA1	Message	Date
Strycher	b96f20140f	chore(#457): remove em-dash characters from source ... Ben's style rule: no em-dash character in copy, docs, or code comments (it reads as an AI tell), and the repo is going public. Replaced the em-dashes in code comments and English UI strings with commas, colons, or periods, whichever reads best. User-facing strings were hand-tuned for natural punctuation rather than a blanket comma. Preserved the lone "no data" glyph placeholders (a standalone dash used as a not-available indicator in status displays); those are a design element, not prose. Regenerated app_localizations*.dart from app_en.arb (the English fallback for untranslated keys propagates to every locale's generated file). Non-English ARB translations left untouched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2 months ago
Strycher	664f2675e5	feat(#407): wire config-profile import into Observer settings ... ConfigProfileImportScreen: browse the curated catalog (default OffbandMesh profiles.json) or enter any source URL (tail-detection routes catalog vs single profile), then open the #406 preview/apply screen with the fetched profile. Surfaces skipped-entry counts and fetch/parse errors inline. Observer settings gains an 'Import config profile' entry that opens it with the live ObserverConfigService. Completes the observer chain (#404-407); ready for the #408 hardware test. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2 months ago
Strycher	67db108520	feat(#80): brokers screen + Observer-pane entry ... The broker pool gets its own screen, reached from a "MQTT brokers" row in the Observer pane (replacing the read-only inline list and its stale "pending firmware support" note). - MqttBrokersScreen: a tile per broker (tap -> editor, long-press -> Enable / Disable / Edit / Clear), and a + FAB that opens the next empty slot (disabled when all 10 are full) -- matching channels_screen's FAB-add pattern. Each action re-reads only the affected slot, never the full pool dump. - Observer pane: the broker section is now a navigational row showing "N configured - M enabled"; the editor is wired in end-to-end. 3/3 screen tests green; full suite green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	3 months ago
Strycher	31c0674330	fix(#81): stop the observer config feature from slowing the channel sync ... Three observer-delta fixes (per the #80 sync diagnosis / G2): - A: settings screen gates the Observer category via context.select on the supported flag, not a connector-wide context.watch -- the watch rebuilt the whole settings screen on every sync frame, thrashing the UI thread. - B: a flat Save re-reads only the flat settings (refresh includeBrokers:false), never the 84-frame broker pool -- no BLE re-flood for a display toggle. - C: the initial observer read is deferred until the device's channel/contact sync settles, so it never competes with that sync for BLE. TDD: B (no OCFG_BROKERS on a flat refresh) + C (refresh deferred while syncing, fires once idle). Full observer suite green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	3 months ago
Strycher	f56a6ac58f	fix(#79): degrade gracefully when the broker dump fails (G2 finding) ... The G2 BLE log showed the config protocol works (GETs return values; the broker dump starts) but the firmware's broker dump stalls without BROKERS_END, so getBrokers() times out. The client was treating that as a TOTAL failure -- discarding the 7 flat settings it read cleanly and blanking the pane. Now the broker pool loads independently: refresh() builds + shows the flat config even when getBrokers fails, flags brokersUnavailable, and the pane shows the broker section as "unavailable" instead of going stale. Flat settings stay usable. TDD red->green; full observer suite (39) green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	3 months ago
Strycher	7825225e73	fix(#78): surface partial-refresh failures + validate status_interval (G1 follow-up) ... Closes the 2 MINOR findings from the G1 re-review (#76): - MINOR-A: ObserverConfigService.refresh() no longer wipes lastError / clears stale on a PARTIAL read. A null from any getFlat is a failed read; the snapshot is marked stale and the error kept (error-visibility). - MINOR-B: the settings pane validates status_interval against the firmware range (10-3600) before sending; an out-of-range value is not put on the wire and the user is told. TDD: both tests RED first (current sent '5'; refresh wiped the error), GREEN after. Full observer suite (37 tests) green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	3 months ago
Strycher	708f168d45	feat(#75): harden observer settings UI + lock behavior (U1) ... Hardened the staged-save pane (settings_screen capability gate already correct): - Normalize an unexpected device rotation to a valid SegmentedButton segment {0,180} so the control always has a valid selection and never echoes an out-of-range value back on save. - Disable Save during a refresh (no save/refresh race on the controllers). - digitsOnly formatter on status-interval (firmware still range-checks). - Keys on the SSID/password fields for robust widget-test targeting. 4 widget tests pin the security-sensitive behavior: saves send ONLY changed keys, a blank password keeps the stored secret, an entered password is sent as wifi.pwd then the field clears, rotation is normalized, stale/error surfaced (SAFELANE §6). Full observer suite (33 tests) green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	3 months ago
Strycher	a31b8146d5	feat(#64): observer settings UI + capability gate ... - screens/settings/observer_settings_view.dart: staged-save pane for WiFi (ssid/pwd/enabled), MQTT region (iata/status_interval), display (always_on/rotation 0|180), with Save (changed keys only) + Refresh + stale/error banners; the broker pool renders read-only (enable/clear await the firmware F-task). - settings_screen.dart: register the Observer category, gated on ObserverConfigService.supported (re-evaluated as the connector's offband_caps flips on connect/disconnect). - connector/meshcore_connector.dart: parse the offband_caps byte (device-info byte 82, after path_hash_mode) + expose offbandCaps. - services/observer_config_service.dart: supported computed live from the connector (version gate + cap bit). - main.dart: provide ObserverConfigService. Strings are English-only pending l10n ARB keys. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	3 months ago