meshcore-client

Commit Graph

Author	SHA1	Message	Date
Strycher	83f6360f7e	fix(#529 ): give repeater CLI commands their own timeout budget The CLI timeout used calculateTimeout, which mirrors the firmware's calcDirectTimeoutMillisFor and estimates ONE-WAY delivery. A CLI command is a request, an execution and a reply, so the budget was structurally short. Measured against rpt-01 on 910.525 MHz / SF7 / BW 62.5k / CR 4:5, where the old window was 4074 ms: 27 commands sent, 12 replies matched, and 4 of those 12 arrived after the client had already given up, at 6.17 s, 8.28 s, 15.52 s and 20.33 s against a median of 2.75 s. calculateCliTimeout sums four terms, each with a source rather than a chosen value: outbound leg calculateTimeout, which is what it actually models cliReplyDelayMs 600, firmware CLI_REPLY_DELAY_MILLIS, unconditional reply leg the reply is a second packet the ACK formula omits retrieval budget replies are pull-based; the radio raises MSG_WAITING and the app must ask, granting itself 5000 ms per attempt across 3 retries The retrieval term is derived from the sync constants rather than restated, so the command timeout cannot drift below the layer it depends on. That is the #530 invariant holding by construction, not by two numbers being maintained in agreement. Execution time is deliberately not modelled. The same verb, wifi on 30, returned in both 2.31 s and 20.33 s, so it is not a per-command constant that could be tabulated. The retrieval term carries that tail. The reply leg uses physics only. The predictor is trained on direct-message ACK latency, so asking it about a CLI reply leg would be extrapolation; that is #534 and #535, not this change. Tests cover the construction, the never-below-retrieval invariant, growth with path length, coverage of the 20.33 s worst case actually observed, and negatively that the direct-message ACK path is untouched. Part of epic #473. Does not change the reported duration string (#531) or the stale-prefix fallback (#532), and does nothing for commands that draw no reply at all (#541).	2 months ago

Author

SHA1

Message

Date

Strycher

83f6360f7e

fix(#529 ): give repeater CLI commands their own timeout budget

The CLI timeout used calculateTimeout, which mirrors the firmware's
calcDirectTimeoutMillisFor and estimates ONE-WAY delivery. A CLI command
is a request, an execution and a reply, so the budget was structurally
short.

Measured against rpt-01 on 910.525 MHz / SF7 / BW 62.5k / CR 4:5, where
the old window was 4074 ms: 27 commands sent, 12 replies matched, and 4
of those 12 arrived after the client had already given up, at 6.17 s,
8.28 s, 15.52 s and 20.33 s against a median of 2.75 s.

calculateCliTimeout sums four terms, each with a source rather than a
chosen value:

  outbound leg      calculateTimeout, which is what it actually models
  cliReplyDelayMs   600, firmware CLI_REPLY_DELAY_MILLIS, unconditional
  reply leg         the reply is a second packet the ACK formula omits
  retrieval budget  replies are pull-based; the radio raises MSG_WAITING
                    and the app must ask, granting itself 5000 ms per
                    attempt across 3 retries

The retrieval term is derived from the sync constants rather than
restated, so the command timeout cannot drift below the layer it depends
on. That is the #530 invariant holding by construction, not by two
numbers being maintained in agreement.

Execution time is deliberately not modelled. The same verb, wifi on 30,
returned in both 2.31 s and 20.33 s, so it is not a per-command constant
that could be tabulated. The retrieval term carries that tail.

The reply leg uses physics only. The predictor is trained on
direct-message ACK latency, so asking it about a CLI reply leg would be
extrapolation; that is #534 and #535, not this change.

Tests cover the construction, the never-below-retrieval invariant, growth
with path length, coverage of the 20.33 s worst case actually observed,
and negatively that the direct-message ACK path is untouched.

Part of epic #473. Does not change the reported duration string (#531)
or the stale-prefix fallback (#532), and does nothing for commands that
draw no reply at all (#541).

1 Commits (83f6360f7ec0bd94cf844e1e4ccbb032ef3c879d)