meshcore-client

Commit Graph

Author	SHA1	Message	Date
Strycher	74e461ba48	fix(#699 ): apply pre-PR review, never block the main thread in the backstop Gemini review (gemini-2.5-pro, docs/llm-consultations) flagged that the 5 s backstop acquired mMethodCallMutex blockingly on the main looper, an ANR class. It now tryAcquires and re-posts itself after 250 ms when a callback holds the mutex. The other two findings were verified and rejected with reasons recorded in the PR body: the disconnectAllDevices race is pre-existing upstream (and naive mutex acquisition there would deadlock the flutterRestart path, which already holds the semaphore), and the untranslated new strings follow this repo's standing l10n process. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2 months ago
Strycher	8a7946972b	fix(#696 ): close leaked GATT handles in the vendored Android plugin Three changes to FlutterBluePlusPlugin.java, per the #689 diagnosis: 1. onConnectionStateChange(CONNECTED): close the handle a map overwrite replaces. A replaced handle is unreachable forever and holds the link and a GATT client slot until process death, which is exactly what the owner's force-stop evidence showed. 2. disconnect: 5 s backstop. If Android never delivers DISCONNECTED for the handle we asked to disconnect, force gatt.close(), untrack it, and synthesize the disconnect event (mirrors the existing cancel-while-connecting path, reason code 23789259). Also caps the Dart layer's 35 s wait at ~5 s. 3. disconnect with no tracked handle now logs at WARN so the orphan fingerprint is visible in exported logs. Vendored version marked 8.2.2+offband.1. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2 months ago
Strycher	3944895550	chore(#695 ): vendor pristine flutter_blue_plus_android 8.2.2 Pristine import of pub.dev flutter_blue_plus_android-8.2.2 into packages/, wired via dependency_overrides, mirroring the WinRT vendor pattern from #686. FBP License v1.4 and BSD NOTICE retained. Verified against the pub cache file-by-file: 9 of 12 files byte-identical; AndroidManifest.xml, LICENSE and FlutterBluePlusPlugin.java differ ONLY in end-of-line whitespace (1, 4 and 11 lines respectively; the byte-perfect license text also ships as LICENSE.md, which is byte-identical). No content changes; verified with git diff --ignore-space-at-eol. Release APK builds clean against the vendored copy before any patch. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2 months ago

Author

SHA1

Message

Date

Strycher

74e461ba48

fix(#699 ): apply pre-PR review, never block the main thread in the backstop

Gemini review (gemini-2.5-pro, docs/llm-consultations) flagged that the
5 s backstop acquired mMethodCallMutex blockingly on the main looper, an
ANR class. It now tryAcquires and re-posts itself after 250 ms when a
callback holds the mutex. The other two findings were verified and
rejected with reasons recorded in the PR body: the disconnectAllDevices
race is pre-existing upstream (and naive mutex acquisition there would
deadlock the flutterRestart path, which already holds the semaphore),
and the untranslated new strings follow this repo's standing l10n
process.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Strycher

8a7946972b

fix(#696 ): close leaked GATT handles in the vendored Android plugin

Three changes to FlutterBluePlusPlugin.java, per the #689 diagnosis:
1. onConnectionStateChange(CONNECTED): close the handle a map overwrite
   replaces. A replaced handle is unreachable forever and holds the link
   and a GATT client slot until process death, which is exactly what the
   owner's force-stop evidence showed.
2. disconnect: 5 s backstop. If Android never delivers DISCONNECTED for
   the handle we asked to disconnect, force gatt.close(), untrack it, and
   synthesize the disconnect event (mirrors the existing
   cancel-while-connecting path, reason code 23789259). Also caps the
   Dart layer's 35 s wait at ~5 s.
3. disconnect with no tracked handle now logs at WARN so the
   orphan fingerprint is visible in exported logs.

Vendored version marked 8.2.2+offband.1.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Strycher

3944895550

chore(#695 ): vendor pristine flutter_blue_plus_android 8.2.2

Pristine import of pub.dev flutter_blue_plus_android-8.2.2 into
packages/, wired via dependency_overrides, mirroring the WinRT vendor
pattern from #686. FBP License v1.4 and BSD NOTICE retained.

Verified against the pub cache file-by-file: 9 of 12 files
byte-identical; AndroidManifest.xml, LICENSE and
FlutterBluePlusPlugin.java differ ONLY in end-of-line whitespace
(1, 4 and 11 lines respectively; the byte-perfect license text also
ships as LICENSE.md, which is byte-identical). No content changes;
verified with git diff --ignore-space-at-eol. Release APK builds
clean against the vendored copy before any patch.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

3 Commits (3f1997e8d29a2e7e87d7732afef424e17c100e2d)