7 Commits (0c405bb6590bdd96decfc96735fe3891617abe0b)

Author	SHA1	Message	Date
Strycher	7a2fca929a	ci(#464): guard against em-dash characters in lib/ and test/ ... Add .github/scripts/check_no_emdash.py and run it as the first step of the analyze job, so it fails in seconds before the flutter setup. It rejects the em-dash character (U+2014) in lib/ and test/ source (comments and string literals) plus app_en.arb, excluding generated files, non- English ARB, and the lone "no data" glyph placeholder ('—' as an entire quoted value). Stops the regression that #457 and #462 had to sweep by hand. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2 months ago
Strycher	b7584bd0c2	chore(#352): generate drift code in CI instead of committing it ... Replaces the stopgap (53f87f5) that committed lib/storage/drift/offband_database.g.dart to green CI. Restores the repo's "generated files are not committed" convention: - dropped the .gitignore negation; the .g.dart is gitignored + untracked (git rm --cached, working copy kept) - added `dart run build_runner build --delete-conflicting-outputs` immediately after `flutter pub get` in every Dart job: flutter_dart (analyze), build.yml (all 6), release-signed (android-signed), deploy-web (before build_pipe) - keeps the drift_dev 2.34.0 / drift 2.34.2 / build_runner ^2.15.1 pins from the stopgap for deterministic generation Verified locally on the bench toolchain (3.44.1): deleted the working .g.dart, ran build_runner from scratch (regenerated cleanly), confirmed the generated file passes `dart format --set-exit-if-changed` and full `flutter analyze --fatal-infos --fatal-warnings` is clean with the file generated (not tracked). For #335 / PR #348. Agent: SapphireCompass (session 8d755b5e)	2 months ago
Strycher	1d6558ef8a	chore(#331): pin Flutter to 3.44.1 in every workflow ... Three different Flutter versions were in play and none was the bench: build.yml channel: stable (floating, resolving to 3.44.6) flutter_dart.yml channel: stable (floating) deploy.yml pinned 3.41.2, with a comment claiming it matched local development, which had not been true for months bench 3.44.1 / Dart 3.12.1 A floating toolchain is tolerable for a compile check and not tolerable once CI produces signed release artifacts (#330), so this lands first. Pinned all 8 flutter-action usages to 3.44.1, matching the bench exactly, so "works locally" and "works in CI" mean the same thing. Verified against Flutter's release index that 3.44.1 is a published stable release (2026-06-01, Dart 3.12.1) rather than assuming a locally-installed version was publicly fetchable. Corrected deploy.yml's misleading local-parity comment rather than leaving it to mislead the next reader. Note: CI's green history is on 3.44.6 or later, so pinning DOWN may surface a break the newer toolchain masked. That is the intent. If it breaks, fix the break or move the bench up deliberately; do not re-float the pin. GIPHY_API_KEY as a CI secret was the third item of Phase 3 in #321. It is deliberately NOT included here, is not dropped, and is flagged on #331 for the owner's decision, since it is a credential only they can create. Part of epic #312, plan #321 (Phase 3).	2 months ago
Strycher	8ea5ede1dc	chore(#322): upload build artifacts + build on dev pushes ... Two diagnostics faults from #313, fixed together: 1. Dead push trigger. build.yml and flutter_dart.yml declared `push: branches: [main]`, but no `main` branch exists in this repo (default is `dev`), so the push half of every trigger had never fired. Nothing built on merge. Added `dev` to both; `main` is created separately after this merges. 2. No artifacts. All six platform jobs stopped at `flutter build`, so every binary CI produced was discarded with the runner. Added actions/upload-artifact to the four jobs that produce something installable or servable: android build/app/outputs/flutter-apk/app-release.apk windows build/windows/x64/runner/Release/ linux build/linux/x64/release/bundle/ web build/web/ ios and macos are compile checks only and upload nothing: ios is built --no-codesign so it is not installable, and macos is kept as a compile check per the owner's decision on #321. Artifacts carry run number + commit SHA so a build traces back to a commit, and use if-no-files-found: error so a wrong path fails loudly rather than silently publishing an empty artifact. Android artifacts are debug-signed for now; real signing is Phase 5. The web artifact is the plain `flutter build web` output, not the build_pipe versioned build used for deploys; Phase 4 addresses that. Part of epic #312, plan #321 (Phase 1, owner-approved).	2 months ago
446564	ddee76ced2	add flutter test to actions	8 months ago
446564	2525b9425b	reduce jobs for flutter and dart ... no need to setup the env twice the exact same way as they don't conflict	8 months ago
446564	b786c90514	combine flutter and dart actions ... reduce time to complete and stop running twice for pull requests	8 months ago