6 Commits (dev)

Author	SHA1	Message	Date
Strycher	a124100acc	fix(#103): re-arm broker-pool GET timeout per frame (inactivity watchdog) ... The broker-pool GET put a single fixed 6s deadline on the entire paginated dump. A large pool (6+ brokers) streams field-by-field over ~8s and blew the deadline, so the client falsely reported the pool as not finished even though the device sent it all (the END terminator arrives after the client gave up). Re-arm an inactivity Timer on each received frame: a steadily-streaming dump never times out; only a genuine stall (no frame for the timeout window) fails. Adds a TDD test - a slow-but-steady dump, frames under the timeout but total far over it, must complete. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	4 weeks ago
Strycher	e3740278e5	feat(#80): broker editor service write ops (save handshake, clear, re-GET) ... The write half of the broker editor, against RedCreek's confirmed field-at-a-time contract. The existing 0xC0 key/value command already carries the broker keys -- no new wire codes -- so the codec comment at observer_config_client.dart:166 is stale, not a gap. - saveBroker(): disable a live slot first, write each changed field, write `enabled` LAST. Stops at the first ERR/timeout and reports the failed field -- a partial save leaves the slot disabled, never live-corrupt (activation guard). TDD: ordering + partial-failure tests. - clearBroker(): mqtt.broker.<slot>.clear. - getBroker(): single-slot re-GET via 14 per-field GETs (recovery / post-save read), not the 84-frame pool dump. Password is write-only -> best-effort. Key spellings (mqtt.broker.N.enabled / .clear, scalar field GET) are inferred from the existing scheme; they're the one thing the joint firmware test confirms. 12/12 service tests green. UI (brokers screen + editor) next. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	4 weeks ago
Strycher	31c0674330	fix(#81): stop the observer config feature from slowing the channel sync ... Three observer-delta fixes (per the #80 sync diagnosis / G2): - A: settings screen gates the Observer category via context.select on the supported flag, not a connector-wide context.watch -- the watch rebuilt the whole settings screen on every sync frame, thrashing the UI thread. - B: a flat Save re-reads only the flat settings (refresh includeBrokers:false), never the 84-frame broker pool -- no BLE re-flood for a display toggle. - C: the initial observer read is deferred until the device's channel/contact sync settles, so it never competes with that sync for BLE. TDD: B (no OCFG_BROKERS on a flat refresh) + C (refresh deferred while syncing, fires once idle). Full observer suite green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	4 weeks ago
Strycher	f56a6ac58f	fix(#79): degrade gracefully when the broker dump fails (G2 finding) ... The G2 BLE log showed the config protocol works (GETs return values; the broker dump starts) but the firmware's broker dump stalls without BROKERS_END, so getBrokers() times out. The client was treating that as a TOTAL failure -- discarding the 7 flat settings it read cleanly and blanking the pane. Now the broker pool loads independently: refresh() builds + shows the flat config even when getBrokers fails, flags brokersUnavailable, and the pane shows the broker section as "unavailable" instead of going stale. Flat settings stay usable. TDD red->green; full observer suite (39) green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	4 weeks ago
Strycher	7825225e73	fix(#78): surface partial-refresh failures + validate status_interval (G1 follow-up) ... Closes the 2 MINOR findings from the G1 re-review (#76): - MINOR-A: ObserverConfigService.refresh() no longer wipes lastError / clears stale on a PARTIAL read. A null from any getFlat is a failed read; the snapshot is marked stale and the error kept (error-visibility). - MINOR-B: the settings pane validates status_interval against the firmware range (10-3600) before sending; an out-of-range value is not put on the wire and the user is told. TDD: both tests RED first (current sent '5'; refresh wiped the error), GREEN after. Full observer suite (37 tests) green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	4 weeks ago
Strycher	e3a0873fd5	test(#69): adversarial service test suite (A2, TDD-RED) ... 4 tests for ObserverConfigService via a fake connector (subclass override of the 4 members the service uses -- no production change). 2 green (capability gate, happy-path setFlat). 2 RED BY DESIGN, documenting the Gemini findings to be fixed by S1 (#73): - BLOCKER #1: overlapping getFlat/setFlat cross responses (single-flight is assumed, not enforced) -- setFlat receives the GET's value, not its ACK. - MINOR #6: a secret key name leaks into the error string ("SET wifi.pwd failed: ..."). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	4 weeks ago