2 Commits (dev)

Author	SHA1	Message	Date
Strycher	e452ab4805	feat(#383): track who reacted, not just the count ... Reactions stored only a Map<String,int> of emoji to count, so "who reacted" was unanswerable and MeshCore One's tap-to-see-who had nothing to show against. This captures the reactor for every reaction, both our own r: format and the PocketMesh / MeshCore One format. Data layer only. The tap-a-badge-to-see-who UI is a separate follow-on; this makes the data available and does not change any screen. Additive by design. A new reactionSenders field (Map<String,List<String>>, emoji -> reactor names) sits alongside the existing count map, serialised under a new JSON key. Both maps are always written. An older build reading a newer store ignores the unknown key and still gets correct counts from reactions; it never hits the hard `value as int` cast that would fail the whole message-list load (the #355 data-loss shape). Records written before this field load with an empty sender map, so their counts survive with names simply absent. - ChannelMessage + Message: new reactionSenders field, constructor, copyWith - both stores: serialise the new key; deserialise via a shared ReactionHelper.reactionSendersFromJson that returns empty for a missing key and skips malformed entries rather than throwing - applyReaction: records the reactor and dedups per reactor per emoji. This is persistent dedup (survives restart), unlike the connector's in-memory processed-set. A pre-existing count with no sender list is incremented from its stored value, not recomputed from the partial list, so old counts are preserved. - connector: threads the reactor name into all reaction paths. Channel uses the frame sender; a room resolves the author via fourByteRoomContactKey; an outgoing reaction is attributed to self. - pending queue: retry now hands the stored reactor to its callback Tests: reactor capture, two-reactor count, same-reactor no-double-count, pre-#383 count preservation, and JSON round-trip + backward-compat + malformed-entry handling for the new field. Full suite 604 passing. Epic #376. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2 months ago
Strycher	0e926ad0c2	feat(#380): parse PocketMesh / MeshCore One emoji reactions ... Reactions sent from MeshCore One arrived as junk text: an emoji line followed by an 8-character token such as "dyps6yf0". Those tokens are Crockford Base32 target-message hashes, the second line of a two-line reaction payload we did not recognise. Receive-side only. Offband keeps sending its own r:hhhh:ii format; their client already parses ours, so nothing about what we transmit changes. Wire format (confirmed against a live capture, see #378): channel: {emoji}@[{targetSender}]\n{hash} direct: {emoji}\n{hash} hash: sha256(body utf8 + timestamp uint32 LE seconds)[0:5], Crockford Base32, 8 chars, lowercase The body is hashed without the channel "SenderName: " prefix, which is why the sender travels in @[...] instead. - crockford_base32.dart: encode and normalise, 12-bit accumulator so the web target's 32-bit bitwise ops cannot truncate a 40-bit value - pocketmesh_reaction.dart: hash and a parser mirroring the reference implementation, with a conservative leading-emoji check so a real message is never swallowed - reaction_helper.dart: ReactionInfo carries a dialect; applyReaction picks the matching hash and, for the channel form, requires an exact sender-name match (a node name can carry emoji and variation selectors) - pending_reactions.dart: a reaction arriving before its target is held and retried rather than silently dropped, bounded at 50 entries with a 15 minute TTL and a warn-level log on expiry (closes the silent-drop path in #382) - the channel dedup key now includes the reacting sender, so two people sending the same emoji no longer collapse into one - notification tray summarises the foreign format as a reaction instead of showing the raw token Known limitation: on channels with Smaz or Cyr2Lat enabled the wire text differs from the text we store, so a hash computed by another client will not match. Flagged for a decision rather than worked around. Epic #376. Fast-follow #383 adds reactor identity. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2 months ago