4 Commits (dev)

Author	SHA1	Message	Date
diffwireauto	762b60dc96	fix(#710): init flserial mutexes before the reader thread can use them ... fl_open started SerialThread and only then called mtx_init. Upstream's thread locked a mutex only after its first read returned data, so the gap rarely mattered; #710's room check locks inFifo_mutex on the thread's first pass, which made the race reachable on every connect. The mutexes are now initialised right after the FlSerial is allocated, before open() can throw, so _fl_close_slot also never destroys an uninitialised mutex after a failed open. Both copies stay identical. Found by the pre-PR Gemini review. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	1 month ago
Strycher	03266e709e	fix(#710): flserial never overwrites incoming serial bytes ... flserial's reader thread copied every byte into an 8 KB ring that overwrote the oldest bytes when full, and told Dart about data only once the port went idle. The RK4 sends its 350-contact list (about 52 KB) in about 0.17 s, so most of it was overwritten before the app read it: the app saw 106-154 contacts and #660's contacts were lost. The thread now reads only as much as the ring has room for. When the ring is full it leaves the bytes in the OS driver, and USB flow control holds the radio, so nothing is dropped. The ring is 256 KB (the size the header already declared as MAX_PORT_FIFO_LEN, and a power of two as the ring's mask needs); the per-read chunk stays 8 KB on the thread stack. Dart is called back during a burst (4 KB waiting or 10 ms) and whenever the ring fills, not only when the port goes idle. Same change in the macOS copy of the source (macos/Classes), which was identical. (std::min) is parenthesised because the Windows headers define a min macro. Verified on the owner's RK4 (read-only harness driving the DLL): new DLL 350/350 in every mode, including a reader 2 s late, zero bytes skipped; the old DLL, as the control, got 345 app-like and 54 (8191 bytes, the old ring's capacity) when 300 ms or 2 s late. Epic #702. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	1 month ago
Strycher	3f4bd23f08	chore(#709): dart format the vendored flserial Dart files for CI ... Whitespace only, from dart format, so CI's repo-wide format check passes. Same step #696 took for the vendored Android BLE plugin. Epic #702. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	1 month ago
Strycher	c1ffa3302b	chore(#709): vendor pristine flserial 4821631 into packages/flserial ... Pristine import of MeshEnvy/flserial at 48216310061efc8d5d217cc18014fc2cb501646e (MIT, Grzegorz Lesniak), the exact commit the app already pinned, into packages/flserial, with the dependency switched from git to a path. Mirrors the #695/#686 vendor pattern. Vendored with git itself (fetch of that commit, read-tree --prefix), so every file is the upstream blob: all 70 files verified blob-for-blob against the commit. Left out, as #695 did: example/, .github/ and .vscode/. No behaviour change. The Windows release build compiles the plugin from the vendored path and produces a flserial.dll of the same size as the installed one. pubspec.lock also picks up flutter_blue_plus_android 8.2.2+offband.1, the version dev's own vendored package already declares. The fix for the 8 KB ring that overwrote contact-sync bytes (#704) follows in #710. Epic #702. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	1 month ago