meshcore-client

Commit Graph

Author	SHA1	Message	Date
diffwireauto	64978061ea	feat(#638 ): move notifications from bottom SnackBar to a top toast The bottom-anchored SnackBar sat on top of the chat composer. A SnackBar is positioned by its Scaffold and can only be raised with a near-full-height bottom margin, which (per Flutter's ClipRect + heightFactor reveal) delays the content until the end of the animation and makes the whole screen a hit target, so this renders through the root Overlay instead. showDismissibleSnackBar keeps its name and every existing call site. Its parameter list is trimmed to the four callers actually pass; the rest were used by nobody, so any future use is now a compile error rather than a silently ignored argument. persist is preserved: the sender-error path relies on it to keep an error on screen until read. Also routes the two composer-screen block confirmations and the five inline ScaffoldMessenger call sites through the helper so placement is consistent where a composer exists. Gemini review: nested-InkWell splash on a dismissing swipe fixed; the route-scoping finding did not apply (MaterialApp installs one root ScaffoldMessenger, app.dart:1047, and this app has no nested one, so the old SnackBars already outlived route pops); replace-instead-of-queue is deliberate and noted on #522. Agent: TurquoiseBridge (session 82d77b2f) Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	12 hours ago
Strycher	bd43642d72	fix(#580 ): keep a truncated caplog and offer to save/share it A truncated caplog download used to completeError and discard every received byte, so the user got nothing from a buffer still intact on the device (a tester lost 8461/8608 bytes, 98.3%, deterministically per firmware#711 so retry can't help). Now truncation is a soft outcome: - downloadCaplog() returns a CaplogDownload (bytes + received/expected/chunks + truncated) instead of throwing; busy/timeout still throw. - serial_capture_screen still writes + LogExport.shareFile the partial bytes, marks the file "# PARTIAL ..." with the counts, and shows a non-fatal warning instead of a red error. - Button label is now platform-aware (Download & save on desktop, & share on mobile) via LogExport.actionVerb, matching the App/BLE log screens. Replaces CaplogTruncatedException with CaplogDownload. Reassembler unchanged (already keeps the bytes). Adds CaplogDownload contract tests. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	6 days ago
Strycher	b96f20140f	chore(#457 ): remove em-dash characters from source Ben's style rule: no em-dash character in copy, docs, or code comments (it reads as an AI tell), and the repo is going public. Replaced the em-dashes in code comments and English UI strings with commas, colons, or periods, whichever reads best. User-facing strings were hand-tuned for natural punctuation rather than a blanket comma. Preserved the lone "no data" glyph placeholders (a standalone dash used as a not-available indicator in status displays); those are a design element, not prose. Regenerated app_localizations*.dart from app_en.arb (the English fallback for untranslated keys propagates to every locale's generated file). Non-English ARB translations left untouched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2 months ago
Strycher	fc119b1832	feat(#430 ): live STATUS polling + empty-buffer guard From Ben's testing: - The buffer readout went stale while idle (STATUS poll only ran during capture). Split the poll from the elapsed tick: the STATUS poll now runs continuously while the screen is on a connected caplog device (stops only on disconnect/dispose); the 1s elapsed tick stays capture-only. - An empty download now shows "Buffer is empty - nothing to download" instead of saving a 0-byte file. analyze clean; full suite 643 green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2 months ago
Strycher	ed8bfdf503	fix(#430 ): accept 176-byte frames (caplog chunks were being rejected) The frame decoder capped companion frames at 172, but the firmware's real MAX_FRAME_SIZE is 176 (BaseSerialInterface.h, "+4 for transport codes"). Full-size caplog CHUNK frames (176 B) were silently rejected; only the final sub-172 partial chunk survived, so a download reassembled just the last chunk (e.g. "received 95 of 5141"). Caplog is the first feature to use full frames, so nothing exposed this before. - usb_serial_frame_codec.dart: usbSerialMaxPayloadLength 172 -> 176. - serial_capture_screen.dart: erase-on-start (Start / Start&Reboot) for a clean session ("didn't start at 0"). - 3 decoder regression tests; 113 tests total green; analyze clean. Root cause confirmed with firmware (TopazHill): firmware streams the full buffer correctly (wire trace 5175/5175); the client decoder dropped oversized chunks. My earlier firmware-ring hypothesis was wrong. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2 months ago
Strycher	7d03a43bb7	fix(#430 ): cap-bit gating + reconnect re-detect + Start&Reboot Fixes the reboot-test failure (support latched "unsupported" after the reconnect window) and reworks the boot-log UX per Ben. - meshcore_protocol.dart: offbandCapCaplog (0x20) + firmwareSupportsOffbandCaplog (0x20 bit AND FIRMWARE_VER_CODE >= 17), mirroring the block-cap pattern. - meshcore_connector.dart: supportsOffbandCaplog getter. - serial_capture_screen.dart: gate support on the static cap bit (reactive via the connector), not a one-shot STATUS probe, so it never latches "unsupported" after a reboot. Derive capturing state from device STATUS so an auto-resumed capture (post firmware #428) shows STOP not START. Cancel timers on disconnect, re-query STATUS on reconnect. New red "Start & Reboot" (no timer) boot-log flow. - 4 cap-gate unit tests; 18 caplog tests total green; analyze clean. Root cause confirmed with firmware (TopazHill): caplog cap bit (0x20) is advertised statically across reboots; the client's probe raced the reconnect window and latched. Firmware #428 (persist flag + boot capture) is the other half. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2 months ago
Strycher	b665b7f2ba	feat(#430 ): add "Reboot device" button for boot-log capture (#428 ) Confirmation-gated Reboot action on the serial-capture screen so an operator can enable capture, reboot the radio, and record the boot log for retrieval (the #428 boot-log flow). Available while capturing; uses the existing connector.rebootDevice(). Full boot-log capture needs firmware retained-enable (#428); the client affordance lands now. flutter analyze clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2 months ago
Strycher	ce2d0b5741	feat(#430 ): serial-capture screen + Debug-category entry Slice 2b UI. SerialCaptureScreen drives the 0xC4 caplog control + download from the prior commits: probe support (STATUS) on open, start/stop capture (default 5-min window or until stopped) with live elapsed + auto-stop + buffer fill, download to a file handed to LogExport.shareFile, and erase. Reached from Settings > Debug. English-only strings for now (localization follow-up, mirrors LogExport #427); capture duration is screen-local (persisting it is a small follow-up). flutter analyze clean on all touched files; 14 connector unit tests green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2 months ago

8 Commits (dev)