From c20bbf7d800e80578d65885296fec60376153473 Mon Sep 17 00:00:00 2001 From: Strycher Date: Sun, 14 Jun 2026 23:20:43 -0400 Subject: [PATCH] fix(#18): drop redundant per-change refreshDeviceInfo in Privacy section Human testing found Privacy controls slow to respond. _PrivacySection._apply called refreshDeviceInfo() after every toggle/dropdown change -- a 5-frame device re-query (deviceQuery, appStart, battery, customVars, autoAddFlags) that does not even re-fetch telemetry. setTelemetryModeBase already updates the connector's local state and calls notifyListeners(), so the refresh was pure overhead. Removed it; apply is now a single setOtherParams frame, matching the auto-add section's responsiveness. Co-Authored-By: Claude Opus 4.8 --- lib/screens/settings_screen.dart | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/screens/settings_screen.dart b/lib/screens/settings_screen.dart index 7538c6e..6fd62ab 100644 --- a/lib/screens/settings_screen.dart +++ b/lib/screens/settings_screen.dart @@ -1053,7 +1053,6 @@ class _PrivacySectionState extends State<_PrivacySection> { _advertLocPolicy ? 1 : 0, _multiAcks, ); - await widget.connector.refreshDeviceInfo(); } while (_applyAgain); } catch (e) { if (!mounted) return;