fix(#793): apply pre-PR review, log name length not the name, and re-log on SELF_INFO
Gemini gate, three findings, all verified against the source before acting. ACCEPTED: the first log line reported a budget computed from a null name. `_selfName` is only assigned while parsing SELF_INFO (line ~6127), which arrives after CMD_APP_START, long after the MTU listener attaches. Now logged on either input changing, with the reason named: `(mtu)` and `(self-info)`. Worth recording because the review had the direction backwards: it said the early line would overstate the budget. It understates it. `_senderNameBytes(null)` returns the 31-byte maximum, so a null name produces the largest possible prefix and the smallest possible channel budget. The line was pessimistic, not optimistic. Same defect, opposite sign, and a maintainer reading it would have been misled the other way. ACCEPTED: the budget also drifts if the name changes mid-session. The SELF_INFO hook covers the case that matters, since that is where the name arrives or changes. ACCEPTED, and it matters more than the review framed it: the name is no longer logged, only its length. These files get attached to public issues, and a radio name is usually an amateur callsign, which resolves publicly to a real name and address. The length is the entire input to the budget, so nothing diagnostic is lost. Logs `nameLen=N`, or -1 when unknown, which also makes the null-name state visible rather than silently rendering as empty. analyze clean, format clean, 1088 tests pass. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>release/1.6.0
parent
c40fbba9d6
commit
c0379c356b
Loading…
Reference in new issue