fix(#684): apply pre-PR review, never show the notice while disconnected
Gemini gate (2.5-pro) findings, verified against source before acting. ACCEPTED, real defect: the notice would have appeared on every disconnect. `_activeTransport` defaults to bluetooth and is reset to it on teardown, the device is null while disconnected so `mtuNow` is unavailable, and `effectiveMaxFrameSize` therefore returns the same 20-byte floor an unreported MTU produces. Neither chat screen pops on disconnect, so the composer stays built. The banner would have blamed the link for a small packet size when there was no link. Now gated on `isConnected`. ACCEPTED in substance: a permanent error-red banner over a link that legitimately fits only a few characters is noise, and noise is what teaches people to ignore the banner that matters. Kept the 16-byte threshold, since lowering it would let the misleading 4-byte case through, and split the severity instead: 0 bytes is an error, 1-15 is informational. REJECTED, unfounded: a semanticLabel on the icon. Flutter's Icon wraps its glyph in ExcludeSemantics and only announces a label when one is given (icon.dart:348-356), so an unlabelled icon is already decorative, and the two Text children carry the whole message. Comment added so it is not "fixed" later. analyze clean, format clean, 962 tests pass. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>fix/717-linux-web-mtu
parent
2939d4644b
commit
b90cc6e88c
Loading…
Reference in new issue