From b31f81cbd71d9440476db385dde7e276a65e5284 Mon Sep 17 00:00:00 2001
From: Strycher <strycher@gmail.com>
Date: Mon, 20 Jul 2026 02:26:43 -0400
Subject: [PATCH] chore(#331): pin Flutter to 3.44.1 in every workflow

Three different Flutter versions were in play and none was the bench:

  build.yml         channel: stable (floating, resolving to 3.44.6)
  flutter_dart.yml  channel: stable (floating)
  deploy.yml        pinned 3.41.2, with a comment claiming it matched
                    local development, which had not been true for months
  bench             3.44.1 / Dart 3.12.1

A floating toolchain is tolerable for a compile check and not tolerable
once CI produces signed release artifacts (#330), so this lands first.

Pinned all 8 flutter-action usages to 3.44.1, matching the bench exactly,
so "works locally" and "works in CI" mean the same thing. Verified against
Flutter's release index that 3.44.1 is a published stable release
(2026-06-01, Dart 3.12.1) rather than assuming a locally-installed
version was publicly fetchable.

Corrected deploy.yml's misleading local-parity comment rather than
leaving it to mislead the next reader.

Note: CI's green history is on 3.44.6 or later, so pinning DOWN may
surface a break the newer toolchain masked. That is the intent. If it
breaks, fix the break or move the bench up deliberately; do not re-float
the pin.

GIPHY_API_KEY as a CI secret was the third item of Phase 3 in #321. It
is deliberately NOT included here, is not dropped, and is flagged on
#331 for the owner's decision, since it is a credential only they can
create.

Part of epic #312, plan #321 (Phase 3).
---
 .github/workflows/build.yml        | 12 ++++++------
 .github/workflows/deploy.yml       |  6 +++---
 .github/workflows/flutter_dart.yml |  2 +-
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 58abccd..4720f5e 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -18,7 +18,7 @@ jobs:
           java-version: "17"
       - uses: subosito/flutter-action@v2
         with:
-          channel: "stable"
+          flutter-version: "3.44.1"
           cache: true
       - name: Cache Gradle
         uses: actions/cache@v4
@@ -45,7 +45,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: subosito/flutter-action@v2
         with:
-          channel: "stable"
+          flutter-version: "3.44.1"
           cache: true
       - run: flutter pub get
       - run: flutter build ios --release --no-codesign --no-pub
@@ -56,7 +56,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: subosito/flutter-action@v2
         with:
-          channel: "stable"
+          flutter-version: "3.44.1"
           cache: true
       - name: Install Linux build deps
         run: sudo apt-get update && sudo apt-get install -y clang cmake ninja-build pkg-config libgtk-3-dev
@@ -76,7 +76,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: subosito/flutter-action@v2
         with:
-          channel: "stable"
+          flutter-version: "3.44.1"
           cache: true
       - run: flutter pub get
       - run: flutter build macos --release --no-pub
@@ -87,7 +87,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: subosito/flutter-action@v2
         with:
-          channel: "stable"
+          flutter-version: "3.44.1"
           cache: true
       - run: flutter pub get
       - run: flutter build web --release --no-pub
@@ -105,7 +105,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: subosito/flutter-action@v2
         with:
-          channel: "stable"
+          flutter-version: "3.44.1"
           cache: true
       - run: flutter pub get
       - run: flutter build windows --release --no-pub
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
index d53a271..42ed701 100644
--- a/.github/workflows/deploy.yml
+++ b/.github/workflows/deploy.yml
@@ -18,9 +18,9 @@ jobs:
       - name: Setup Flutter
         uses: subosito/flutter-action@v2
         with:
-          channel: 'stable'
-          # Match local development version which provides Dart 3.11.0
-          flutter-version: '3.41.2'
+          # Pinned to the bench toolchain (Dart 3.12.1). Was 3.41.2 with a
+          # comment claiming local parity that had not been true for months.
+          flutter-version: "3.44.1"
 
       - name: Setup Bun
         uses: oven-sh/setup-bun@v2
diff --git a/.github/workflows/flutter_dart.yml b/.github/workflows/flutter_dart.yml
index e267557..bff800d 100644
--- a/.github/workflows/flutter_dart.yml
+++ b/.github/workflows/flutter_dart.yml
@@ -17,7 +17,7 @@ jobs:
       - name: Set up Flutter
         uses: subosito/flutter-action@v2
         with:
-          channel: stable
+          flutter-version: "3.44.1"
 
       - name: Install dependencies
         run: flutter pub get