From 0cd9dddd09c5b59c507106e904de1331ebd2b5cc Mon Sep 17 00:00:00 2001 From: diffwireauto <330573775+diffwireauto@users.noreply.github.com> Date: Sat, 7 Nov 2026 04:53:11 -0500 Subject: [PATCH] fix(#1109): wait up to 5h for notarization, not 30 minutes The first submission for the new Developer ID was still In Progress at Apple when the 30-minute wait ran out, failing a run whose signing had passed. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/macos-signed.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/macos-signed.yml b/.github/workflows/macos-signed.yml index 2dcb0a3c..df01dd0c 100644 --- a/.github/workflows/macos-signed.yml +++ b/.github/workflows/macos-signed.yml @@ -33,6 +33,9 @@ jobs: macos-signed: runs-on: macos-latest environment: apple-signing # required-reviewer gate; do not remove + # Apple's notary queue can hold a new Developer ID's submissions for hours. + # GitHub's job limit is 6h; the notarytool wait below fits inside it. + timeout-minutes: 355 steps: - uses: actions/checkout@v4 @@ -136,7 +139,7 @@ jobs: ditto -c -k --keepParent "${APP}" "${SUBMIT}" OUT="${RUNNER_TEMP}/notarize.json" xcrun notarytool submit "${SUBMIT}" --key "${P8}" --key-id "${ASC_API_KEY_ID}" \ - --issuer "${ASC_API_ISSUER_ID}" --wait --timeout 30m --output-format json > "${OUT}" || true + --issuer "${ASC_API_ISSUER_ID}" --wait --timeout 5h --output-format json > "${OUT}" || true cat "${OUT}" STATUS="$(jq -r '.status // empty' "${OUT}")" ID="$(jq -r '.id // empty' "${OUT}")"