From e2b04a6e17bbc11f8d5b191d2788aa59ddded726 Mon Sep 17 00:00:00 2001
From: Tom Early <n7tae@tearly.net>
Date: Thu, 4 Jun 2020 11:51:42 -0700
Subject: [PATCH] error msgs for CUDPSocket

---
 UDPSocket.cpp | 8 ++++++--
 UDPSocket.h   | 8 +-------
 2 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/UDPSocket.cpp b/UDPSocket.cpp
index f781acb..4ced971 100644
--- a/UDPSocket.cpp
+++ b/UDPSocket.cpp
@@ -101,12 +101,16 @@ size_t CUDPSocket::Read(unsigned char *buf, const size_t size, CSockAddress &Ip)
 	unsigned int len = sizeof(struct sockaddr_storage);
 	auto rval = recvfrom(m_fd, buf, size, 0, Ip.GetPointer(), &len);
 	if (0 > rval)
-		std::cerr << "Receive error on port " << m_addr << ": " << strerror(errno) << std::endl;
+		std::cerr << "Read error on port " << m_addr << ": " << strerror(errno) << std::endl;
 
 	return rval;
 }
 
 void CUDPSocket::Write(const void *Buffer, const size_t size, const CSockAddress &Ip) const
 {
-	sendto(m_fd, Buffer, size, 0, Ip.GetCPointer(), Ip.GetSize());
+	auto rval = sendto(m_fd, Buffer, size, 0, Ip.GetCPointer(), Ip.GetSize());
+	if (0 > rval)
+		std::cerr << "Write error to " << Ip << ", " << strerror(errno) << std::endl;
+	else if ((size_t)rval != size)
+		std::cerr << "Short write, " << rval << "<" << size << " to " << Ip << std::endl;
 }
diff --git a/UDPSocket.h b/UDPSocket.h
index fe62bcd..70d0940 100644
--- a/UDPSocket.h
+++ b/UDPSocket.h
@@ -25,26 +25,20 @@
 class CUDPSocket
 {
 public:
-	// constructor
 	CUDPSocket();
 
-	// destructor
 	~CUDPSocket();
 
-	// open & close
 	bool Open(const CSockAddress &addr);
 	void Close(void);
+
 	int GetSocket(void) const { return m_fd; }
 	unsigned short GetPort() const { return m_addr.GetPort(); }
 
-	// read
 	size_t Read(unsigned char *buf, const size_t size, CSockAddress &addr);
-
-	// write
 	void Write(const void *buf, const size_t size, const CSockAddress &addr) const;
 
 protected:
-	// data
 	int m_fd;
 	CSockAddress m_addr;
 };