864044ff8b
replace sprintf with snprintf;
2 years ago
258feb0173
put the naughty message in the right spot;
2 years ago
942a53069b
add support to gate GRP_VCH_GRANT messages from going to peers with no affiliations for a TG (if the TG is configured for affiliated only);
2 years ago
afa47f4b58
fix bonehead mistake not cleaning up arrays before reallocating them;
2 years ago
a7f9cb93be
fix issue handling $F7E NAC; implement $F7F NAC support;
2 years ago
ae3a03b521
fix LC_GROUP_UPDT using duplicated data;
2 years ago
9b828fe7a4
ensure the lookup table thread is named; don't display the not transmitting CC messages unless the test timer is not paused; add aggressive watchdog logging for when timers exceed 1s intervals; split adj. site and affiliation updating into a separate thread (huge adj. site updates could be the cause of main loop processing delays); ensure threads are properly shutdown; increase P25 adj site update timer from 30 seconds to 60 seconds (5 minutes of no updates will now FAIL an adj. site);
2 years ago
36099367c8
fix condition where the Log and ActivityLog would overflow the character buffer by no properly calculating the length of the va_args string (this should resolve buffer overflow terminations on GCC 13+);
2 years ago
0ad47a1989
be a little less obtuse about the NAK reason in the FNE log;
2 years ago
cbb0af42ba
fix some minor DVRS/conventional weirdness;
2 years ago
a7e727a7ec
ensure we don't end up with badness;
2 years ago
01af69a954
make sure the data length for P25 is twice the PDU length; add support to log if a dedicated CC stops transmitting from the host perspective (the logic for this is: is host in appropriate digital mode for CC, is the modem reporting no Tx, has the modem reported its status initially, and is the CC in a running state);
2 years ago
a1a0065a74
when logging what the peer reports as identity use 8 character padding;
2 years ago
1cdd2aa56d
normalize log formatting better;
2 years ago
9cfde0e57e
report peer identity string in influx data; make sure non-alternate port reporting properly reports peer identity;
2 years ago
e57541c135
it would help if this was a string...;
2 years ago
b1e0058986
whoops handle boolean with yes/no output response instead of 0/1;
2 years ago
bcd2cf21e7
add support to report the textual identity in the logs for a peer along with its peer ID in most cases;
2 years ago
75dbc9e025
refactor parrot frame storage; add support to allow parrot responses to go only to the peer for which the parrot call originated;
2 years ago
e4aca9fc4f
don't register a CC with itself; be more clear in the config YAML that the controlChannel block should be left at defaults for dedicated control channels;
2 years ago
c249ee5803
fix offset issue for network generated TSDUs;
2 years ago
5650db1657
for LDU LC's pass thru any non-standard MFIDs without any further processing as-is;
2 years ago
c7b0fc3a9d
add support to encode a GRP_AFF_RSP as an AMBT (this is just the data serialization part and not the actual business logic in the host);
2 years ago
d980da74be
small fix to make preferred sites work via REST
2 years ago
41044d2271
fix a potential situation where we may get a length stuck on the queue (this shouldn't happen but, this is protection logic to ensure it never happens);
2 years ago
24082b9652
P25 data ( #52 )
...
NOTE: this does not indicate full P25 data support as working yet; this commit refactors a lot of the baseline PDU handling code, and better handles both confirmed and unconfirmed PDU data blocks, there is still some more work to do, I just didn't want p25_data to start getting overly out of sync with master.
* rework modem protocol to support variable length frames up to 64k; refactor P25 PDU handling to support TIA-102 minimum 512 byte frames;
* fix PDU length its 512 bytes not 500; ignore instead of report invalid modem frames; add double length checking to HostSetup;
* add support to send P25 long frames to the modem;
* adjust FIFO size to 522 (fits a single PDU frame); remove extra debug displays; match fixed FIFO sizes between modem and host;
* correct weird inverted CRC-9 that sometimes happen;
* ensure netPDU is reset at the beginning of a network data call; fix lengh used by data block dumping;
* fix some buffer lengths;
2 years ago
cf2469a2aa
revert previous change to ControlSignaling that pulled wrong commit from p25_data branch;
2 years ago
137dfbe918
use site data sysId for U_REG_RSP for a successful AUTH_RESP;
2 years ago
be7230d68d
used incorrect variables to set the WACN and system ID for the auth demand OSP (thanks max);
2 years ago
7e3e006fd1
fix comment typo;
2 years ago
e0b6da51fb
make the network presence announcment (VC -> CC and CC -> FNE) timing configurable (this value is in seconds); refactor RF channel enumeration, RF channels are now enumerated in their own class ChannelLookup instead of being integrated into AffiliationLookup, this allows the flexibility to update and change channel information at runtime; add support for VC -> CC presence/registration to tell the CC what the REST information is for that VC, this makes the restAddress and restPort entries for the voiceChNo list in the config.yml optional, the only mandatory fields are channelId, channelNo and restPassword;
2 years ago
f5a5d83f4b
fix potential issue with full group affiliation update;
2 years ago
0f7eabff82
implement support for peers that identify themselves as "conventional" to ignore affiliated talkgroup rules and be able to receive all traffic if the FNE is configured to allow promiscuous operation; implement extremely preliminary support to allow a CC to claim a VC peer, allowing for appropriate grouping of peers for trunked sites;
2 years ago
6d738432e2
fix missing break for AUTH_RESP case;
2 years ago
f8aa80a63f
continued work on P25 PDU handling (this has a long way to go...);
2 years ago
c99efa1f14
fix issue with bad offsets for AUTH_RESP data (this happened back in Decemeber when the payload array layout was altered);
2 years ago
424c7fa35a
fix missed nullptr checks for if networking is disabled;
2 years ago
7cc2b99000
pass VSELP1/2 frames (this is experimental, in my tests doesn't break anything else, but it could), this will also pass VSELP1/2 frames to the network core but the host doesn't currently carry code to retransmit network VSELP frames over the air [yet];
2 years ago
574ede103e
update hotspot and modem fw submodules;
2 years ago
17fae1d461
fix issue where the timeout timer wasn't running for the network which would never cause the connection to reset after a number of error attempts trying to login to the master;
2 years ago
d5ef9a0cb5
little bit of P25 data work (nothing amazing here yet);
2 years ago
9055e3aaa8
update copyrights;
2 years ago
4d776f6314
add support for DMR T3 adjacent site broadcast;
2 years ago
3d752bc363
add preferred peer ID lists to the REST API;
2 years ago
096efcef1a
ignore affiliation checks for ISSI-type peers, they are excluded from affiliation rule checking;
2 years ago
94da264f55
better handle checking if a peer affiliation table has become invalid (null); better handle cleanup and creation of peer affiliation tables;
2 years ago
690bac453d
remove clearBeforeWrite function argument for a lot of control singalling (and some data) cases, this was an old method of clearing the Tx packet queue before creating a frame to ensure it went out really fast, but shouldn't be done anymore, so I'm removing this so no one gets any bright ideas;
2 years ago
b19c1d5f6a
add support for processing CSBK on the FNE; add support to optionally log TSBK and CSBK network events to InfluxDB;
2 years ago
f603949879
make common strings #defines instead of copy and pasted static text;
2 years ago
1341690653
add call error (failed validation) events to InfluxDB logging;
2 years ago
96a9ba1c03
implement trunking site preference support for TGIDs, this implements a feature by which TGIDs can be gated to allow affiliation to preferred sites, all other non-preferred sites will DENY affiliation causing the radio to attempt to roam to another site (this is a trunking only feature and does not change conventional operation);
2 years ago
7d1af0235b
implement support for reporting activity, diagnostic and call events to an InfluxDB instance;
2 years ago
a8adeeaad7
implement missing parrot delay timer; fix bad implementation where parrot frames were only played if network packets were received (this logic changed when threaded network Rx was implemented);
2 years ago
1ef806fef1
handle edge-case scenario of RTP packet sequence overrun;
2 years ago
856fa98357
make the REST response wait time variable; use a quick response time of 150ms when using REST API during real-time OTA packet processing; add extra logging messages for UDP;
2 years ago
1632019650
port and implement /dmr/rid and /p25/rid REST APIs on the CFNE;
2 years ago
9675f42db5
added ability to save RID/TGID lookups from the FNE to local files
2 years ago
b75389cd47
simple fix for RID list updates, verified on list sizes of 49, 50, 51, 99, 100, and 101
2 years ago
01bd534c8f
fixed RID alias updates not working via REST
2 years ago
5571a71e4e
replace manual lock/unlock with lock_guard to ensure a lock is held in a scope, and released when a scope is closed;
2 years ago
b7c6282767
fix for possible race condition (that shouldn't have happened in the first place), if writeMaster is being used in queueOnly = false, do an immediate network socket write without attempting to enqueue a message;
2 years ago
86d736b0bb
revert change from 0ea6ee0 that changed the RingBuffer const char* to std::string to correct issue where the RingBuffer name is being copied incorrectly; change method for copying name std::string passed to AffiliationLookup; remove accidentally committed debug code;
2 years ago
f000639c7f
ensure m_forceHotspot is initialized to a sane default;
2 years ago
e2514c1f8f
mild include reorg;
2 years ago
31ca17449d
*BEWARE* this commit alters the RPI_ARM cross-compiler and may break things *BEWARE*; implement support for HTTPS SSL REST API configuration; add contrib binary overlay for the RPI_ARM compiler (to add libssl-dev dependences);
2 years ago
cda6b5965f
add support for optional TCP SSL/TLS sockets;
2 years ago
b4f9b2d201
fix some issues with the "unsupported no no mode" that people continue to abuse; correct issue with calculating list offsets when announcing RID lists to the host;
2 years ago
17d69cb950
add support to disable *ALL* passing of P25 ADJ_STS_BCAST from a CFNE instance; properly implement processing of TSDU messages from any peer; implement login flag from CFNEs to identify themselves as external when they are peering;
2 years ago
ecdce85e8a
clean up file;
2 years ago
9dadc06130
I was asked for ASCII art, and I deliver, thus, ASCII art;
2 years ago
c3f9b69454
catch and log certain situations where a buffer in a buffer vector may be released (this is likely due to a non-tread safe network flush); expose size of inclusion, exclusion and rewrite lists so we don't need to copy them to know the size;
2 years ago
ba785f3d91
hide debug here (m_debug/m_verbose should be adhered to in classes as they *optionally* enable debug trace for modules, allowing the LogLevel to be set to 1 and not spam the log/console with unintended debug statements); alter bad handling of a compiler constant string for the Server/User-Agent strings;
2 years ago
1e8a842a30
document functions in the Thread class; add a helper detach() method for future use;
2 years ago
4acb60aeff
add more plumbing to the CFNE for future use;
2 years ago
e7ce1d1f20
report errno errors from pthread_create;
2 years ago
92a5bbd580
treat threadedNetworkRx and threadedACLUpdate with pthread_detach and ensure they will not retain resources waiting for a pthread_join that'll never happen;
2 years ago
d38e8d00da
remove accidental debug code left in last commit;
2 years ago
c4ca72581f
for performance reasons on very noisy/busy setups that may have *lots* of peers, use of an alternate port to service diagnostic and activity log transfers helps ensure the traffic port doesn't become overloaded with data;
2 years ago
8ca4ed5a40
implement a few more CFNE NAK types to notify the peer of invalid conditions; take first steps towards FNE-side authoritative grants by implementing some logic plumbing;
2 years ago
b7ebfa43e4
reorganize source code slightly, we shouldn't define logic in the CPP files for the talkgroup rules data classes, and instead we should define the logic in the header (since logic for these data classes shouldn't be anything complicated anyway);
2 years ago
d8eff1f1f4
got tgid editing via REST mostly working ( #49 )
2 years ago
5d6c99da43
add missing mutex unlocks for the lookup tables (I'm not sure how this hasn't caused a problem); reorganize the code in FNENetwork and make threadedNetworkRx private; add some counting logic to ensure the voice tag classes flush voice frames every 5 peers to ensure timely delivery of packets;
2 years ago
e348b15d7f
for the purpose of performance handle incoming packets in their own threads (NOTE: this commit is *experimental* and may burn your house down and kick your dog, and it most certainly has a memory leak I'm working on somewhere);
2 years ago
c6c1c72f79
institute a hard 250 peer cap on the CFNE for performance, stability and call quality reasons; implement support for the user to configure the connection limit on a CFNE; implement support to resolve a master NAK to a reason on the host;
2 years ago
b28c685ee3
add missing documentation; properly annotate time value; add missing thread join wait;
2 years ago
4632bfb4b9
updated copyrights
2 years ago
18f5d69a36
implemented RID ACL file save
2 years ago
b9c89aebf1
for sanity reasons -- huge RID lists make the log *VERY VERY* noisy, we'll silence this by not logging the toggle events;
2 years ago
86985a5ecc
update peer ping time in RID ACL update; move core network process/read into its own thread;
2 years ago
49343917d6
add copyright lines for Patrick;
2 years ago
0ea6ee07ed
fix missed change of const char* to std::string (GCC 11+ didn't catch this but 4.9 did? Isn't that something?);
2 years ago
eb57f1b5d8
implement functionality to block traffic to specific peers from specific external peers; use std::string over const char* wherever possible to limit pointer passing; implement support in FrameQueue and RawFrameQueue to bypass the queue and directly send messages to specified peers (useful in some situations for packets to be immediately dispatched vs queuing and batching); chunk RID list transmissions to aid in increasing performance (this will likely also need to be done with the TGID lists in the future as well); refactor transmitting ACL lists to peers into its own spun off thread so we don't block the main network processing loop (and infact, this requires documentation; since at a certain peer size DVM network partitioning should be considered to reduce the number of concurrent peers serviced by any given FNE and to better load balance connections across a network, instead of relying on a singular central FNE); implement /peer/count REST API to simply return the known connected count of peers; disable the forced ACL list update functionality (for now);
2 years ago
a279b33876
Add RID alias to RID ACL ( #48 )
...
* initial RID alias support
* don't use toggle for an RID update from the REST API
2 years ago
987e944d4b
add flag to denote traffic flow for external peers (that is a peer connection the CFNE makes to another CFNE);
2 years ago
7dc850669a
reorganize messages for ADJ_STS_BCAST;
2 years ago
0ce9a374ee
change source file to match configuration file change;
2 years ago
af516f33fd
report local and remote peer ID information for peer connection log messages;
2 years ago
98dacab03c
refactor RPTL handling slightly to better handle a RPTL condition while the peer state is in connection state 4 (RUNNING); refactor RPTL slightly to better handle non-valid connection states for RPTL (i.e. non-INVALID/CONNECTED, or RUNNING); reword logging messages for clarity; increase default configuration max pings from 5 to 10, this has the effect of making the time out for a peer 50s in total length before the connection is considered stale (for future reference the formula for the timeout is: PingTime * MaxPings = TimeoutInSeconds);
2 years ago
083517326e
fix nullptr reference for a non-existent peer affiliation list (can happen if the peer hasn't completed login); slightly reorganize RPTL (this stil has some bizarre problem);
2 years ago
e523798e3c
log offending PEER IDs for illegal TSDUs, because .. we want to know who these people are...;
2 years ago
34ae323166
implement option to disable the CFNE from sending P25 ADJ_STS_BCAST to external peers (that is CFNE's the CFNE receiving the ADJ_STS_BCAST is connected to via peers list in the configuration file); add logging around the RPTL NAK condition; don't validate the connection state when performing a connection cleanup for an RPTL NAK; attempt to erase a peer ID from the peer table if during an RPTL the connection is null (this should never happen); correct a bunch if TG validation issues; correct condition where the FNE would try to pass traffic with *both* srcId and dstId 0 (this should never happen on any protocol really, and if there is some scenario that requires it, contact me on Discord please); add more processing for TSDUs to perform TGID checks and other validations;
2 years ago
0e20d4fec0
add separate config option for reporting peer pings to the log; add extra logging around an RPTL NAK condition;
2 years ago
64e3e91e2e
fix missed message;
2 years ago
25d81b93a4
make sure the ping response message is displayed when verbose is set to true;
2 years ago
6219929cd5
preliminary support for management APIs RID (Query/Add/Delete/Commit), TGID (Query/Add/Delete/Commit) [note: commit doesn't work pending modification to RadioIdLookup and TalkgroupRulesLookup to implement commit/saving to disk];
2 years ago
49f1b02ccf
add preliminary support for CFNE to have the "affiliated" flag to pass traffic;
2 years ago
345495076b
fix issue with the FNE not properly rewriting TGIDs for configured peers (the original implementation was slighly naive in assumptions, the new implementation techincally allows rewrites to *any* peer *from* any peer not just ISSI peers); perform some minor cleanup of the REST classes; revert change in ClientConnection and ServerConnection initializing the m_buffer class variable (hopefully this may fix some strange issues being seen);
2 years ago
bafad81722
fix idiotic issue where armhf for RPI-ARM failed because the 4.9 compiler is garbage;
2 years ago
80d38ccf3a
refactor and reorganize network socket handling classes to be more consistent;
2 years ago
6fb3ede4ef
whoops inadvertant bad logic;
2 years ago
91a995af43
correct issue where writeMaster wasn't being properly treated as an immediate (we cannot queue peer master packets like we can master peer packets); fix issue with peer title for affiliation lists;
2 years ago
7d1c233875
I'm a moron;
2 years ago
a4ec7fbfa8
add a check for RTP payload type $57 (which we deprecated) so that its essentially ignored, so people on older versions can abuse the newer software; ensure we don't try to transmit terminators for calls that didn't exist on the first place;
2 years ago
e75caf0337
correct some edge case issues with nullptrs at inappropriate times; check for error condition trying to transmit encrypted network frames with no key;
2 years ago
9e27875bb8
ensure network is a valid instantiation before trying to run;
2 years ago
5b5efcbe9d
add support for network announcement of unit registration, deregistration and group affiliation so the FNE can collate the data more accurately; implement REST API on dvmfne to support retreiving the list of known affiliations; correct a bug in enumeration of RID and TGID lists that could cause weirdness; remote unnecessary "control" RTP payload type and just use a singluar payload type;
2 years ago
3e5fe8b349
update submodules;
2 years ago
5a5104ba2f
treewide: perform general refactor of file headers, I've modified the file headers to follow rules from: https://www.kernel.org/doc/html/next/process/license-rules.html , this trims/compresses the file header section a bit reducing the number of lines at the top of every file quite a bit, going forward all new files should follow this new format (if its good enough for the Linux kernel, its good enough for me);
2 years ago
0687b1da80
include TCP headers;
2 years ago
bad8129d7d
file header updates;
2 years ago
d9e2458722
implement support for low-level TCP sockets; deprecate and remove new_unique macro and use appropriate std::make_unique; apply various clang linting;
2 years ago
68bfae72bb
remove unused variable;
2 years ago
8ff7067eca
mplement experimental support to AES-256 encrypt the network connection; cleanup some instances where buffers were not being cleaned up properly; cleanup some of the AESCrypto implementation; remove references to some little used compiler macros;
2 years ago
9b55c67ac9
fix issue where the converged FNE would continue to update an unauth'ed PEERs ping time resulting in it never timing out properly;
2 years ago
eba4db6104
refactor RTP code slightly to better handle tracking the RTP timestamp properly;
2 years ago
5ed3d79a0b
fix inversion of MINOR_VERSION; fix missing HOST_SW_API markers;
2 years ago
1447d9dbe0
fix bad C++14 handling of overrides (forgot the override keyword);
2 years ago
f0be2e0079
fix incorrect variable set in P25 SiteData; add VIM YouCompleteMe project configuration;
2 years ago
051dc0eb7f
allow overriding of group voice channel data in IOSP_GRP_VCH; make sure to instantiate values to sane defaults;
2 years ago
6d5e35d361
fix issue with net active and roamer reaccess bits in OSP_RFSS_STS_BCAST; add helper function to AffiliationLookup to allow for reverse resolving of grants from source to destination; migrate FNEPeerConnection from a non-pointer reference to a pointer (this allows better tracking of values without copying the connection structure);
2 years ago
1c28bed062
fixup log messages; allow special CRC bypass conditions; add roamer reaccess flag to OSP_RFSS_STS_BCAST;
2 years ago
7513bccf52
refactor PROPERTY_PLAIN and READONLY_PROPERTY_PLAIN;
2 years ago
c94ddc3421
remove unused macros; use __SET_UINT16B for some BaseNetwork values;
2 years ago
9611af1374
reorganize utility macros from Defines.h to Utils.h; cleanup unneeded includes in some places; cleanup files;
2 years ago
f7ecb54b86
during shutdown ensure the log network pointer is cleared (prevents a shutdown/exit SEGFAULT);
2 years ago
98cf9513ba
correct badness when dealing with ISSI peers;
2 years ago
d0e4e08b31
allow some BaseNetwork functions to be overridden by inheriting classes; allow extension payload header length to be modified by the user;
2 years ago
926c9f0c77
better comment these buffer value helpers;
2 years ago
6c3735befe
make hex2Bin and bin2Hex util functions;
2 years ago
9fb2201139
code cleanup; some minor modifications for out-of-band software;
2 years ago
140b4ecd3c
further cleanup/rework of CMake scripts;
2 years ago
1e4bdbd1fa
typo;
2 years ago
7b95ddff95
refactor and rework the CMake build system slightly (so it behaves better when compiled out-of-tree, shhh);
2 years ago
bde6284308
ensure FNE software reports itself differently; make host Network class private section protected so the FNE codebase can inherit from it; create PeerNetwork inherited class on FNE;
2 years ago
cf0d8bb430
port RTP header changes from fnecore for better handling the RTP timestamp; relabel conference FNE to converged FNE; refactor version slightly so that the running DVM host version is properly reported to the FNE and when saved to modem configuration area;
2 years ago
abbe6cd41c
properly queue FNE peer messages (these are distinct from peers connected *to* the FNE, FNE peer messages are messages sent to FNE masters that are "ISSI"ed); better handle logging activity logging;
2 years ago
c60b69b54e
add conference FNE REST API to report the currently configured TGID list;
2 years ago
9bd06b916a
use better terminology for FNE peer TGID rewriting;
2 years ago
2226e1e6f7
implement confernece FNE API to force list updates on demand; better organize FNE dvmcmd commands;
2 years ago
bf72dcbee8
add support to picojson for uint64_t; correct issue with conference bridge FNE never incrementing a connections ping counter; implement /status and /peerlist APIs for conference bridge REST API; implement support for /peerlist in dvmcmd;
2 years ago
Bryan Biedenkapp
W3AXL
W3AXL