From ff66d6bbe2b7852080d77aba6f119b1a7fc6b8fe Mon Sep 17 00:00:00 2001 From: Bryan Biedenkapp Date: Mon, 10 Jul 2023 19:47:28 -0400 Subject: [PATCH] ensure DataHeader's are always passed by reference; --- src/p25/lc/AMBT.cpp | 4 ++-- src/p25/lc/AMBT.h | 6 +++--- src/p25/lc/tsbk/MBT_IOSP_ACK_RSP.cpp | 2 +- src/p25/lc/tsbk/MBT_IOSP_ACK_RSP.h | 2 +- src/p25/lc/tsbk/MBT_IOSP_CALL_ALRT.cpp | 2 +- src/p25/lc/tsbk/MBT_IOSP_CALL_ALRT.h | 2 +- src/p25/lc/tsbk/MBT_IOSP_EXT_FNCT.cpp | 2 +- src/p25/lc/tsbk/MBT_IOSP_EXT_FNCT.h | 2 +- src/p25/lc/tsbk/MBT_IOSP_GRP_AFF.cpp | 2 +- src/p25/lc/tsbk/MBT_IOSP_GRP_AFF.h | 2 +- src/p25/lc/tsbk/MBT_IOSP_MSG_UPDT.cpp | 2 +- src/p25/lc/tsbk/MBT_IOSP_MSG_UPDT.h | 2 +- src/p25/lc/tsbk/MBT_IOSP_STS_UPDT.cpp | 2 +- src/p25/lc/tsbk/MBT_IOSP_STS_UPDT.h | 2 +- src/p25/lc/tsbk/MBT_ISP_AUTH_RESP_M.cpp | 2 +- src/p25/lc/tsbk/MBT_ISP_AUTH_RESP_M.h | 2 +- src/p25/lc/tsbk/MBT_ISP_AUTH_SU_DMD.cpp | 2 +- src/p25/lc/tsbk/MBT_ISP_AUTH_SU_DMD.h | 2 +- src/p25/lc/tsbk/MBT_ISP_CAN_SRV_REQ.cpp | 2 +- src/p25/lc/tsbk/MBT_ISP_CAN_SRV_REQ.h | 2 +- src/p25/lc/tsbk/MBT_OSP_ADJ_STS_BCAST.cpp | 2 +- src/p25/lc/tsbk/MBT_OSP_ADJ_STS_BCAST.h | 2 +- src/p25/lc/tsbk/MBT_OSP_AUTH_DMD.cpp | 2 +- src/p25/lc/tsbk/MBT_OSP_AUTH_DMD.h | 2 +- src/p25/lc/tsbk/MBT_OSP_NET_STS_BCAST.cpp | 2 +- src/p25/lc/tsbk/MBT_OSP_NET_STS_BCAST.h | 2 +- src/p25/lc/tsbk/MBT_OSP_RFSS_STS_BCAST.cpp | 2 +- src/p25/lc/tsbk/MBT_OSP_RFSS_STS_BCAST.h | 2 +- src/p25/lc/tsbk/TSBKFactory.cpp | 4 ++-- src/p25/lc/tsbk/TSBKFactory.h | 4 ++-- src/p25/packet/Data.cpp | 2 +- src/p25/packet/Data.h | 2 +- src/p25/packet/Trunk.cpp | 2 +- src/p25/packet/Trunk.h | 2 +- 34 files changed, 39 insertions(+), 39 deletions(-) diff --git a/src/p25/lc/AMBT.cpp b/src/p25/lc/AMBT.cpp index 0a7d4c75..12fac0a0 100644 --- a/src/p25/lc/AMBT.cpp +++ b/src/p25/lc/AMBT.cpp @@ -85,7 +85,7 @@ void AMBT::encode(uint8_t* data, bool rawTSBK, bool noTrellis) /// /// /// -ulong64_t AMBT::toValue(const data::DataHeader dataHeader, const uint8_t* pduUserData) +ulong64_t AMBT::toValue(const data::DataHeader& dataHeader, const uint8_t* pduUserData) { ulong64_t tsbkValue = 0U; @@ -109,7 +109,7 @@ ulong64_t AMBT::toValue(const data::DataHeader dataHeader, const uint8_t* pduUse /// /// /// True, if TSBK was decoded, otherwise false. -bool AMBT::decode(const data::DataHeader dataHeader, const data::DataBlock* blocks, uint8_t* pduUserData) +bool AMBT::decode(const data::DataHeader& dataHeader, const data::DataBlock* blocks, uint8_t* pduUserData) { assert(blocks != nullptr); assert(pduUserData != nullptr); diff --git a/src/p25/lc/AMBT.h b/src/p25/lc/AMBT.h index b0aaea4c..e54e2c46 100644 --- a/src/p25/lc/AMBT.h +++ b/src/p25/lc/AMBT.h @@ -46,7 +46,7 @@ namespace p25 AMBT(); /// Decode a alternate trunking signalling block. - virtual bool decodeMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks) = 0; + virtual bool decodeMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks) = 0; /// Encode a alternate trunking signalling block. virtual void encodeMBT(data::DataHeader& dataHeader, uint8_t* pduUserData) = 0; @@ -57,10 +57,10 @@ namespace p25 protected: /// Internal helper to convert TSBK bytes to a 64-bit long value. - static ulong64_t toValue(const data::DataHeader dataHeader, const uint8_t* pduUserData); + static ulong64_t toValue(const data::DataHeader& dataHeader, const uint8_t* pduUserData); /// Internal helper to decode a trunking signalling block. - bool decode(const data::DataHeader dataHeader, const data::DataBlock* blocks, uint8_t* pduUserData); + bool decode(const data::DataHeader& dataHeader, const data::DataBlock* blocks, uint8_t* pduUserData); /// Internal helper to encode a trunking signalling block. void encode(data::DataHeader& dataHeader, uint8_t* pduUserData); }; diff --git a/src/p25/lc/tsbk/MBT_IOSP_ACK_RSP.cpp b/src/p25/lc/tsbk/MBT_IOSP_ACK_RSP.cpp index 9f41b678..984ab5ff 100644 --- a/src/p25/lc/tsbk/MBT_IOSP_ACK_RSP.cpp +++ b/src/p25/lc/tsbk/MBT_IOSP_ACK_RSP.cpp @@ -53,7 +53,7 @@ MBT_IOSP_ACK_RSP::MBT_IOSP_ACK_RSP() : AMBT() /// /// /// True, if TSBK was decoded, otherwise false. -bool MBT_IOSP_ACK_RSP::decodeMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks) +bool MBT_IOSP_ACK_RSP::decodeMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks) { assert(blocks != NULL); diff --git a/src/p25/lc/tsbk/MBT_IOSP_ACK_RSP.h b/src/p25/lc/tsbk/MBT_IOSP_ACK_RSP.h index 20832f17..3e49a0a1 100644 --- a/src/p25/lc/tsbk/MBT_IOSP_ACK_RSP.h +++ b/src/p25/lc/tsbk/MBT_IOSP_ACK_RSP.h @@ -47,7 +47,7 @@ namespace p25 MBT_IOSP_ACK_RSP(); /// Decode a alternate trunking signalling block. - bool decodeMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks); + bool decodeMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks); /// Encode a alternate trunking signalling block. void encodeMBT(data::DataHeader& dataHeader, uint8_t* pduUserData); diff --git a/src/p25/lc/tsbk/MBT_IOSP_CALL_ALRT.cpp b/src/p25/lc/tsbk/MBT_IOSP_CALL_ALRT.cpp index 276521f8..d5a8172d 100644 --- a/src/p25/lc/tsbk/MBT_IOSP_CALL_ALRT.cpp +++ b/src/p25/lc/tsbk/MBT_IOSP_CALL_ALRT.cpp @@ -53,7 +53,7 @@ MBT_IOSP_CALL_ALRT::MBT_IOSP_CALL_ALRT() : AMBT() /// /// /// True, if TSBK was decoded, otherwise false. -bool MBT_IOSP_CALL_ALRT::decodeMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks) +bool MBT_IOSP_CALL_ALRT::decodeMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks) { assert(blocks != NULL); diff --git a/src/p25/lc/tsbk/MBT_IOSP_CALL_ALRT.h b/src/p25/lc/tsbk/MBT_IOSP_CALL_ALRT.h index 974998e6..6b281950 100644 --- a/src/p25/lc/tsbk/MBT_IOSP_CALL_ALRT.h +++ b/src/p25/lc/tsbk/MBT_IOSP_CALL_ALRT.h @@ -47,7 +47,7 @@ namespace p25 MBT_IOSP_CALL_ALRT(); /// Decode a alternate trunking signalling block. - bool decodeMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks); + bool decodeMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks); /// Encode a alternate trunking signalling block. void encodeMBT(data::DataHeader& dataHeader, uint8_t* pduUserData); diff --git a/src/p25/lc/tsbk/MBT_IOSP_EXT_FNCT.cpp b/src/p25/lc/tsbk/MBT_IOSP_EXT_FNCT.cpp index b7ebd006..3f8b22a6 100644 --- a/src/p25/lc/tsbk/MBT_IOSP_EXT_FNCT.cpp +++ b/src/p25/lc/tsbk/MBT_IOSP_EXT_FNCT.cpp @@ -54,7 +54,7 @@ MBT_IOSP_EXT_FNCT::MBT_IOSP_EXT_FNCT() : AMBT(), /// /// /// True, if TSBK was decoded, otherwise false. -bool MBT_IOSP_EXT_FNCT::decodeMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks) +bool MBT_IOSP_EXT_FNCT::decodeMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks) { assert(blocks != NULL); diff --git a/src/p25/lc/tsbk/MBT_IOSP_EXT_FNCT.h b/src/p25/lc/tsbk/MBT_IOSP_EXT_FNCT.h index b76a6bda..c144c37a 100644 --- a/src/p25/lc/tsbk/MBT_IOSP_EXT_FNCT.h +++ b/src/p25/lc/tsbk/MBT_IOSP_EXT_FNCT.h @@ -47,7 +47,7 @@ namespace p25 MBT_IOSP_EXT_FNCT(); /// Decode a alternate trunking signalling block. - bool decodeMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks); + bool decodeMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks); /// Encode a alternate trunking signalling block. void encodeMBT(data::DataHeader& dataHeader, uint8_t* pduUserData); diff --git a/src/p25/lc/tsbk/MBT_IOSP_GRP_AFF.cpp b/src/p25/lc/tsbk/MBT_IOSP_GRP_AFF.cpp index e32893ba..118fd2c7 100644 --- a/src/p25/lc/tsbk/MBT_IOSP_GRP_AFF.cpp +++ b/src/p25/lc/tsbk/MBT_IOSP_GRP_AFF.cpp @@ -53,7 +53,7 @@ MBT_IOSP_GRP_AFF::MBT_IOSP_GRP_AFF() : AMBT() /// /// /// True, if TSBK was decoded, otherwise false. -bool MBT_IOSP_GRP_AFF::decodeMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks) +bool MBT_IOSP_GRP_AFF::decodeMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks) { assert(blocks != NULL); diff --git a/src/p25/lc/tsbk/MBT_IOSP_GRP_AFF.h b/src/p25/lc/tsbk/MBT_IOSP_GRP_AFF.h index 4fa513e1..640a828f 100644 --- a/src/p25/lc/tsbk/MBT_IOSP_GRP_AFF.h +++ b/src/p25/lc/tsbk/MBT_IOSP_GRP_AFF.h @@ -47,7 +47,7 @@ namespace p25 MBT_IOSP_GRP_AFF(); /// Decode a alternate trunking signalling block. - bool decodeMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks); + bool decodeMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks); /// Encode a alternate trunking signalling block. void encodeMBT(data::DataHeader& dataHeader, uint8_t* pduUserData); diff --git a/src/p25/lc/tsbk/MBT_IOSP_MSG_UPDT.cpp b/src/p25/lc/tsbk/MBT_IOSP_MSG_UPDT.cpp index 5b6396ae..1872f446 100644 --- a/src/p25/lc/tsbk/MBT_IOSP_MSG_UPDT.cpp +++ b/src/p25/lc/tsbk/MBT_IOSP_MSG_UPDT.cpp @@ -54,7 +54,7 @@ MBT_IOSP_MSG_UPDT::MBT_IOSP_MSG_UPDT() : AMBT(), /// /// /// True, if TSBK was decoded, otherwise false. -bool MBT_IOSP_MSG_UPDT::decodeMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks) +bool MBT_IOSP_MSG_UPDT::decodeMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks) { assert(blocks != NULL); diff --git a/src/p25/lc/tsbk/MBT_IOSP_MSG_UPDT.h b/src/p25/lc/tsbk/MBT_IOSP_MSG_UPDT.h index 838837ff..afae7e39 100644 --- a/src/p25/lc/tsbk/MBT_IOSP_MSG_UPDT.h +++ b/src/p25/lc/tsbk/MBT_IOSP_MSG_UPDT.h @@ -47,7 +47,7 @@ namespace p25 MBT_IOSP_MSG_UPDT(); /// Decode a alternate trunking signalling block. - bool decodeMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks); + bool decodeMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks); /// Encode a alternate trunking signalling block. void encodeMBT(data::DataHeader& dataHeader, uint8_t* pduUserData); diff --git a/src/p25/lc/tsbk/MBT_IOSP_STS_UPDT.cpp b/src/p25/lc/tsbk/MBT_IOSP_STS_UPDT.cpp index 30c4f9d6..1cf1f318 100644 --- a/src/p25/lc/tsbk/MBT_IOSP_STS_UPDT.cpp +++ b/src/p25/lc/tsbk/MBT_IOSP_STS_UPDT.cpp @@ -54,7 +54,7 @@ MBT_IOSP_STS_UPDT::MBT_IOSP_STS_UPDT() : AMBT(), /// /// /// True, if TSBK was decoded, otherwise false. -bool MBT_IOSP_STS_UPDT::decodeMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks) +bool MBT_IOSP_STS_UPDT::decodeMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks) { assert(blocks != NULL); diff --git a/src/p25/lc/tsbk/MBT_IOSP_STS_UPDT.h b/src/p25/lc/tsbk/MBT_IOSP_STS_UPDT.h index 561fac52..1abe5b84 100644 --- a/src/p25/lc/tsbk/MBT_IOSP_STS_UPDT.h +++ b/src/p25/lc/tsbk/MBT_IOSP_STS_UPDT.h @@ -47,7 +47,7 @@ namespace p25 MBT_IOSP_STS_UPDT(); /// Decode a alternate trunking signalling block. - bool decodeMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks); + bool decodeMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks); /// Encode a alternate trunking signalling block. void encodeMBT(data::DataHeader& dataHeader, uint8_t* pduUserData); diff --git a/src/p25/lc/tsbk/MBT_ISP_AUTH_RESP_M.cpp b/src/p25/lc/tsbk/MBT_ISP_AUTH_RESP_M.cpp index 443c6141..0b5c23b5 100644 --- a/src/p25/lc/tsbk/MBT_ISP_AUTH_RESP_M.cpp +++ b/src/p25/lc/tsbk/MBT_ISP_AUTH_RESP_M.cpp @@ -74,7 +74,7 @@ MBT_ISP_AUTH_RESP_M::~MBT_ISP_AUTH_RESP_M() /// /// /// True, if TSBK was decoded, otherwise false. -bool MBT_ISP_AUTH_RESP_M::decodeMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks) +bool MBT_ISP_AUTH_RESP_M::decodeMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks) { assert(blocks != NULL); diff --git a/src/p25/lc/tsbk/MBT_ISP_AUTH_RESP_M.h b/src/p25/lc/tsbk/MBT_ISP_AUTH_RESP_M.h index d0af35e4..9b6551a8 100644 --- a/src/p25/lc/tsbk/MBT_ISP_AUTH_RESP_M.h +++ b/src/p25/lc/tsbk/MBT_ISP_AUTH_RESP_M.h @@ -48,7 +48,7 @@ namespace p25 ~MBT_ISP_AUTH_RESP_M(); /// Decode a alternate trunking signalling block. - bool decodeMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks); + bool decodeMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks); /// Encode a alternate trunking signalling block. void encodeMBT(data::DataHeader& dataHeader, uint8_t* pduUserData); diff --git a/src/p25/lc/tsbk/MBT_ISP_AUTH_SU_DMD.cpp b/src/p25/lc/tsbk/MBT_ISP_AUTH_SU_DMD.cpp index daafd754..456d878f 100644 --- a/src/p25/lc/tsbk/MBT_ISP_AUTH_SU_DMD.cpp +++ b/src/p25/lc/tsbk/MBT_ISP_AUTH_SU_DMD.cpp @@ -53,7 +53,7 @@ MBT_ISP_AUTH_SU_DMD::MBT_ISP_AUTH_SU_DMD() : AMBT() /// /// /// True, if TSBK was decoded, otherwise false. -bool MBT_ISP_AUTH_SU_DMD::decodeMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks) +bool MBT_ISP_AUTH_SU_DMD::decodeMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks) { assert(blocks != NULL); diff --git a/src/p25/lc/tsbk/MBT_ISP_AUTH_SU_DMD.h b/src/p25/lc/tsbk/MBT_ISP_AUTH_SU_DMD.h index dfdf26a4..7b9e756c 100644 --- a/src/p25/lc/tsbk/MBT_ISP_AUTH_SU_DMD.h +++ b/src/p25/lc/tsbk/MBT_ISP_AUTH_SU_DMD.h @@ -46,7 +46,7 @@ namespace p25 MBT_ISP_AUTH_SU_DMD(); /// Decode a alternate trunking signalling block. - bool decodeMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks); + bool decodeMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks); /// Encode a alternate trunking signalling block. void encodeMBT(data::DataHeader& dataHeader, uint8_t* pduUserData); diff --git a/src/p25/lc/tsbk/MBT_ISP_CAN_SRV_REQ.cpp b/src/p25/lc/tsbk/MBT_ISP_CAN_SRV_REQ.cpp index d0ec8407..41c4cce5 100644 --- a/src/p25/lc/tsbk/MBT_ISP_CAN_SRV_REQ.cpp +++ b/src/p25/lc/tsbk/MBT_ISP_CAN_SRV_REQ.cpp @@ -53,7 +53,7 @@ MBT_ISP_CAN_SRV_REQ::MBT_ISP_CAN_SRV_REQ() : AMBT() /// /// /// True, if TSBK was decoded, otherwise false. -bool MBT_ISP_CAN_SRV_REQ::decodeMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks) +bool MBT_ISP_CAN_SRV_REQ::decodeMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks) { assert(blocks != NULL); diff --git a/src/p25/lc/tsbk/MBT_ISP_CAN_SRV_REQ.h b/src/p25/lc/tsbk/MBT_ISP_CAN_SRV_REQ.h index 6573bc6a..231130dd 100644 --- a/src/p25/lc/tsbk/MBT_ISP_CAN_SRV_REQ.h +++ b/src/p25/lc/tsbk/MBT_ISP_CAN_SRV_REQ.h @@ -46,7 +46,7 @@ namespace p25 MBT_ISP_CAN_SRV_REQ(); /// Decode a alternate trunking signalling block. - bool decodeMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks); + bool decodeMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks); /// Encode a alternate trunking signalling block. void encodeMBT(data::DataHeader& dataHeader, uint8_t* pduUserData); diff --git a/src/p25/lc/tsbk/MBT_OSP_ADJ_STS_BCAST.cpp b/src/p25/lc/tsbk/MBT_OSP_ADJ_STS_BCAST.cpp index 288c9417..b97b9027 100644 --- a/src/p25/lc/tsbk/MBT_OSP_ADJ_STS_BCAST.cpp +++ b/src/p25/lc/tsbk/MBT_OSP_ADJ_STS_BCAST.cpp @@ -59,7 +59,7 @@ MBT_OSP_ADJ_STS_BCAST::MBT_OSP_ADJ_STS_BCAST() : AMBT(), /// /// /// True, if TSBK was decoded, otherwise false. -bool MBT_OSP_ADJ_STS_BCAST::decodeMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks) +bool MBT_OSP_ADJ_STS_BCAST::decodeMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks) { assert(blocks != NULL); diff --git a/src/p25/lc/tsbk/MBT_OSP_ADJ_STS_BCAST.h b/src/p25/lc/tsbk/MBT_OSP_ADJ_STS_BCAST.h index 858147de..e3efdfa2 100644 --- a/src/p25/lc/tsbk/MBT_OSP_ADJ_STS_BCAST.h +++ b/src/p25/lc/tsbk/MBT_OSP_ADJ_STS_BCAST.h @@ -46,7 +46,7 @@ namespace p25 MBT_OSP_ADJ_STS_BCAST(); /// Decode a alternate trunking signalling block. - bool decodeMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks); + bool decodeMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks); /// Encode a alternate trunking signalling block. void encodeMBT(data::DataHeader& dataHeader, uint8_t* pduUserData); diff --git a/src/p25/lc/tsbk/MBT_OSP_AUTH_DMD.cpp b/src/p25/lc/tsbk/MBT_OSP_AUTH_DMD.cpp index 0157b707..62e9aa54 100644 --- a/src/p25/lc/tsbk/MBT_OSP_AUTH_DMD.cpp +++ b/src/p25/lc/tsbk/MBT_OSP_AUTH_DMD.cpp @@ -74,7 +74,7 @@ MBT_OSP_AUTH_DMD::~MBT_OSP_AUTH_DMD() /// /// /// True, if TSBK was decoded, otherwise false. -bool MBT_OSP_AUTH_DMD::decodeMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks) +bool MBT_OSP_AUTH_DMD::decodeMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks) { assert(blocks != NULL); diff --git a/src/p25/lc/tsbk/MBT_OSP_AUTH_DMD.h b/src/p25/lc/tsbk/MBT_OSP_AUTH_DMD.h index 0132eaf7..7e8e0fcd 100644 --- a/src/p25/lc/tsbk/MBT_OSP_AUTH_DMD.h +++ b/src/p25/lc/tsbk/MBT_OSP_AUTH_DMD.h @@ -48,7 +48,7 @@ namespace p25 ~MBT_OSP_AUTH_DMD(); /// Decode a alternate trunking signalling block. - bool decodeMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks); + bool decodeMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks); /// Encode a alternate trunking signalling block. void encodeMBT(data::DataHeader& dataHeader, uint8_t* pduUserData); diff --git a/src/p25/lc/tsbk/MBT_OSP_NET_STS_BCAST.cpp b/src/p25/lc/tsbk/MBT_OSP_NET_STS_BCAST.cpp index 37c86c2c..77246ad0 100644 --- a/src/p25/lc/tsbk/MBT_OSP_NET_STS_BCAST.cpp +++ b/src/p25/lc/tsbk/MBT_OSP_NET_STS_BCAST.cpp @@ -53,7 +53,7 @@ MBT_OSP_NET_STS_BCAST::MBT_OSP_NET_STS_BCAST() : AMBT() /// /// /// True, if TSBK was decoded, otherwise false. -bool MBT_OSP_NET_STS_BCAST::decodeMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks) +bool MBT_OSP_NET_STS_BCAST::decodeMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks) { assert(blocks != NULL); diff --git a/src/p25/lc/tsbk/MBT_OSP_NET_STS_BCAST.h b/src/p25/lc/tsbk/MBT_OSP_NET_STS_BCAST.h index 079518a9..d250313c 100644 --- a/src/p25/lc/tsbk/MBT_OSP_NET_STS_BCAST.h +++ b/src/p25/lc/tsbk/MBT_OSP_NET_STS_BCAST.h @@ -46,7 +46,7 @@ namespace p25 MBT_OSP_NET_STS_BCAST(); /// Decode a alternate trunking signalling block. - bool decodeMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks); + bool decodeMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks); /// Encode a alternate trunking signalling block. void encodeMBT(data::DataHeader& dataHeader, uint8_t* pduUserData); diff --git a/src/p25/lc/tsbk/MBT_OSP_RFSS_STS_BCAST.cpp b/src/p25/lc/tsbk/MBT_OSP_RFSS_STS_BCAST.cpp index 3c8f07ee..fb6cc2ad 100644 --- a/src/p25/lc/tsbk/MBT_OSP_RFSS_STS_BCAST.cpp +++ b/src/p25/lc/tsbk/MBT_OSP_RFSS_STS_BCAST.cpp @@ -53,7 +53,7 @@ MBT_OSP_RFSS_STS_BCAST::MBT_OSP_RFSS_STS_BCAST() : AMBT() /// /// /// True, if TSBK was decoded, otherwise false. -bool MBT_OSP_RFSS_STS_BCAST::decodeMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks) +bool MBT_OSP_RFSS_STS_BCAST::decodeMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks) { assert(blocks != NULL); diff --git a/src/p25/lc/tsbk/MBT_OSP_RFSS_STS_BCAST.h b/src/p25/lc/tsbk/MBT_OSP_RFSS_STS_BCAST.h index e95fc193..d1af71d7 100644 --- a/src/p25/lc/tsbk/MBT_OSP_RFSS_STS_BCAST.h +++ b/src/p25/lc/tsbk/MBT_OSP_RFSS_STS_BCAST.h @@ -46,7 +46,7 @@ namespace p25 MBT_OSP_RFSS_STS_BCAST(); /// Decode a alternate trunking signalling block. - bool decodeMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks); + bool decodeMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks); /// Encode a alternate trunking signalling block. void encodeMBT(data::DataHeader& dataHeader, uint8_t* pduUserData); diff --git a/src/p25/lc/tsbk/TSBKFactory.cpp b/src/p25/lc/tsbk/TSBKFactory.cpp index 11e84118..5cb0b38e 100644 --- a/src/p25/lc/tsbk/TSBKFactory.cpp +++ b/src/p25/lc/tsbk/TSBKFactory.cpp @@ -247,7 +247,7 @@ std::unique_ptr TSBKFactory::createTSBK(const uint8_t* data, bool rawTSBK) /// /// /// -std::unique_ptr TSBKFactory::createAMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks) +std::unique_ptr TSBKFactory::createAMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks) { assert(blocks != nullptr); @@ -358,7 +358,7 @@ std::unique_ptr TSBKFactory::decode(TSBK* tsbk, const uint8_t* data, bool /// /// /// -std::unique_ptr TSBKFactory::decode(AMBT* ambt, const data::DataHeader dataHeader, const data::DataBlock* blocks) +std::unique_ptr TSBKFactory::decode(AMBT* ambt, const data::DataHeader& dataHeader, const data::DataBlock* blocks) { assert(ambt != nullptr); assert(blocks != nullptr); diff --git a/src/p25/lc/tsbk/TSBKFactory.h b/src/p25/lc/tsbk/TSBKFactory.h index dd1da0ef..7aba61f2 100644 --- a/src/p25/lc/tsbk/TSBKFactory.h +++ b/src/p25/lc/tsbk/TSBKFactory.h @@ -116,7 +116,7 @@ namespace p25 /// Create an instance of a TSBK. static std::unique_ptr createTSBK(const uint8_t* data, bool rawTSBK = false); /// Create an instance of a AMBT. - static std::unique_ptr createAMBT(const data::DataHeader dataHeader, const data::DataBlock* blocks); + static std::unique_ptr createAMBT(const data::DataHeader& dataHeader, const data::DataBlock* blocks); /// Sets the flag indicating CRC-errors should be warnings and not errors. static void setWarnCRC(bool warnCRC) { m_warnCRC = warnCRC; } @@ -127,7 +127,7 @@ namespace p25 /// static std::unique_ptr decode(TSBK* tsbk, const uint8_t* data, bool rawTSBK = false); /// - static std::unique_ptr decode(AMBT* ambt, const data::DataHeader dataHeader, const data::DataBlock* blocks); + static std::unique_ptr decode(AMBT* ambt, const data::DataHeader& dataHeader, const data::DataBlock* blocks); }; } // namespace tsbk } // namespace lc diff --git a/src/p25/packet/Data.cpp b/src/p25/packet/Data.cpp index d2be1c4a..e93e0db3 100644 --- a/src/p25/packet/Data.cpp +++ b/src/p25/packet/Data.cpp @@ -679,7 +679,7 @@ bool Data::hasLLIdFNEReg(uint32_t llId) const /// /// /// -void Data::writeRF_PDU_User(data::DataHeader dataHeader, const uint8_t* pduUserData, bool clearBeforeWrite) +void Data::writeRF_PDU_User(data::DataHeader& dataHeader, const uint8_t* pduUserData, bool clearBeforeWrite) { assert(pduUserData != nullptr); diff --git a/src/p25/packet/Data.h b/src/p25/packet/Data.h index baaed00a..ff87bfd0 100644 --- a/src/p25/packet/Data.h +++ b/src/p25/packet/Data.h @@ -74,7 +74,7 @@ namespace p25 bool hasLLIdFNEReg(uint32_t llId) const; /// Helper to write user data as a P25 PDU packet. - void writeRF_PDU_User(data::DataHeader dataHeader, const uint8_t* pduUserData, bool clearBeforeWrite = false); + void writeRF_PDU_User(data::DataHeader& dataHeader, const uint8_t* pduUserData, bool clearBeforeWrite = false); /// Updates the processor by the passed number of milliseconds. void clock(uint32_t ms); diff --git a/src/p25/packet/Trunk.cpp b/src/p25/packet/Trunk.cpp index fb3c6144..db2d51a1 100644 --- a/src/p25/packet/Trunk.cpp +++ b/src/p25/packet/Trunk.cpp @@ -907,7 +907,7 @@ bool Trunk::processNetwork(uint8_t* data, uint32_t len, lc::LC& control, data::L /// /// /// -bool Trunk::processMBT(DataHeader dataHeader, DataBlock* blocks) +bool Trunk::processMBT(DataHeader& dataHeader, DataBlock* blocks) { if (!m_p25->m_control) { return false; diff --git a/src/p25/packet/Trunk.h b/src/p25/packet/Trunk.h index 6769b479..1ecab020 100644 --- a/src/p25/packet/Trunk.h +++ b/src/p25/packet/Trunk.h @@ -67,7 +67,7 @@ namespace p25 virtual bool processNetwork(uint8_t* data, uint32_t len, lc::LC& control, data::LowSpeedData& lsd, uint8_t& duid); /// Helper used to process AMBTs from PDU data. - bool processMBT(data::DataHeader dataHeader, data::DataBlock* blocks); + bool processMBT(data::DataHeader& dataHeader, data::DataBlock* blocks); /// Helper to write P25 adjacent site information to the network. void writeAdjSSNetwork();