From fe0350473b61d169a781e3421c55e16d53b79116 Mon Sep 17 00:00:00 2001 From: Bryan Biedenkapp Date: Sat, 23 May 2026 09:50:58 -0400 Subject: [PATCH] make metadata unknown opcodes for transfer and announce non-fatal and do not NAK; --- src/fne/network/MetadataNetwork.cpp | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/fne/network/MetadataNetwork.cpp b/src/fne/network/MetadataNetwork.cpp index 98d724c5..7b927f69 100644 --- a/src/fne/network/MetadataNetwork.cpp +++ b/src/fne/network/MetadataNetwork.cpp @@ -377,8 +377,11 @@ void MetadataNetwork::taskNetworkRx(NetPacketRequest* req) break; default: - network->writePeerNAK(peerId, network->createStreamId(), TAG_TRANSFER, NET_CONN_NAK_ILLEGAL_PACKET); - Utils::dump("Unknown transfer opcode from the peer", req->buffer, req->length); + { + LogWarning(LOG_MASTER, "PEER %u, unknown/unsupported transfer opcode %u", peerId, req->fneHeader.getSubFunction()); + if (network->m_debug) + Utils::dump("Unknown/unsupported transfer opcode from the peer", req->buffer, req->length); + } break; } } @@ -691,8 +694,12 @@ void MetadataNetwork::taskNetworkRx(NetPacketRequest* req) } break; default: - network->writePeerNAK(peerId, streamId, TAG_ANNOUNCE, NET_CONN_NAK_ILLEGAL_PACKET); - Utils::dump("Unknown announcement opcode from the peer", req->buffer, req->length); + { + LogWarning(LOG_MASTER, "PEER %u, unknown/unsupported announcement opcode %u", peerId, req->fneHeader.getSubFunction()); + if (network->m_debug) + Utils::dump("Unknown/unsupported announcement opcode from the peer", req->buffer, req->length); + } + break; } } break;