From e7ce1d1f20e4b513a1aa3c0ffb6c524dda215cc4 Mon Sep 17 00:00:00 2001
From: Bryan Biedenkapp <gatekeep@gmail.com>
Date: Fri, 9 Feb 2024 16:27:46 -0500
Subject: [PATCH] report errno errors from pthread_create;

---
 src/common/Thread.cpp           | 10 +++++++++-
 src/fne/network/DiagNetwork.cpp |  6 +++++-
 src/fne/network/FNENetwork.cpp  | 14 ++++++++++++--
 3 files changed, 26 insertions(+), 4 deletions(-)

diff --git a/src/common/Thread.cpp b/src/common/Thread.cpp
index 07cb4206..1ec45af1 100644
--- a/src/common/Thread.cpp
+++ b/src/common/Thread.cpp
@@ -13,7 +13,9 @@
 *
 */
 #include "Thread.h"
+#include "Log.h"
 
+#include <cerrno>
 #include <signal.h>
 #include <unistd.h>
 
@@ -46,7 +48,13 @@ bool Thread::run()
         return m_started;
 
     m_started = true;
-    return ::pthread_create(&m_thread, NULL, helper, this) == 0;
+    int err = ::pthread_create(&m_thread, NULL, helper, this);
+    if (err != 0) {
+        LogError(LOG_NET, "Error returned from pthread_create, err: %d", errno);
+        return false;
+    }
+
+    return true;
 }
 
 /// <summary>
diff --git a/src/fne/network/DiagNetwork.cpp b/src/fne/network/DiagNetwork.cpp
index 5629f797..442467e1 100644
--- a/src/fne/network/DiagNetwork.cpp
+++ b/src/fne/network/DiagNetwork.cpp
@@ -95,7 +95,11 @@ void DiagNetwork::processNetwork()
         req->buffer = new uint8_t[length];
         ::memcpy(req->buffer, buffer.get(), length);
 
-        ::pthread_create(&req->thread, NULL, threadedNetworkRx, req);
+        if (::pthread_create(&req->thread, NULL, threadedNetworkRx, req) != 0) {
+            LogError(LOG_NET, "Error returned from pthread_create, err: %d", errno);
+            delete req;
+            return;
+        }
     }
 }
 
diff --git a/src/fne/network/FNENetwork.cpp b/src/fne/network/FNENetwork.cpp
index 1bd7e3aa..73c597a3 100644
--- a/src/fne/network/FNENetwork.cpp
+++ b/src/fne/network/FNENetwork.cpp
@@ -26,6 +26,7 @@ using namespace network;
 using namespace network::fne;
 
 #include <cassert>
+#include <cerrno>
 #include <chrono>
 
 // ---------------------------------------------------------------------------
@@ -185,7 +186,11 @@ void FNENetwork::processNetwork()
         req->buffer = new uint8_t[length];
         ::memcpy(req->buffer, buffer.get(), length);
 
-        ::pthread_create(&req->thread, NULL, threadedNetworkRx, req);
+        if (::pthread_create(&req->thread, NULL, threadedNetworkRx, req) != 0) {
+            LogError(LOG_NET, "Error returned from pthread_create, err: %d", errno);
+            delete req;
+            return;
+        }
     }
     else {
         // if the DMR handler has parrot frames to playback, playback a frame
@@ -1028,7 +1033,12 @@ void FNENetwork::peerACLUpdate(uint32_t peerId)
     std::stringstream peerName;
     peerName << peerId << ":acl-update";
 
-    ::pthread_create(&req->thread, NULL, threadedACLUpdate, req);
+    if (::pthread_create(&req->thread, NULL, threadedACLUpdate, req) != 0) {
+        LogError(LOG_NET, "Error returned from pthread_create, err: %d", errno);
+        delete req;
+        return;
+    }
+
     if (pthread_kill(req->thread, 0) == 0) {
         ::pthread_setname_np(req->thread, peerName.str().c_str());
     }