From 9e25bb8fbf71bf4d8779a600f8877f749bd1a4bb Mon Sep 17 00:00:00 2001 From: Bryan Biedenkapp Date: Sat, 17 Oct 2026 21:32:52 -0400 Subject: [PATCH] remove DMR disable network grant demand options (it made no sense); --- configs/config.example.yml | 4 ---- src/host/dmr/Control.cpp | 10 ---------- src/host/dmr/Slot.cpp | 23 ++++------------------- src/host/dmr/Slot.h | 1 - 4 files changed, 4 insertions(+), 34 deletions(-) diff --git a/configs/config.example.yml b/configs/config.example.yml index c388aa6d..7bae6938 100644 --- a/configs/config.example.yml +++ b/configs/config.example.yml @@ -198,10 +198,6 @@ protocols: # authentication key is requested from the upstream FNE through the existing LLA key path. requireAuthForReg: false - # Flag indicating whether or not network calls will generate a channel grant. - # (This applies only in conventional operations where channel granting is utilized and RF-only talkgroup - # steering is required.) - disableNetworkGrant: false # Flag indicating whether or not a TGID will be tested for affiliations before being granted. ignoreAffiliationCheck: false # Flag indicating the host should send a network grant demand for conventional traffic. diff --git a/src/host/dmr/Control.cpp b/src/host/dmr/Control.cpp index 761c8597..f33dccc7 100644 --- a/src/host/dmr/Control.cpp +++ b/src/host/dmr/Control.cpp @@ -242,13 +242,6 @@ void Control::setOptions(yaml::Node& conf, bool supervisor, ::lookups::VoiceChDa uint8_t slotNo, uint32_t peerId, uint32_t ssrc, uint32_t streamId) { processInCallCtrl(command, dstId, slotNo); }); } - /* - ** Network Grant Disables - */ - bool disableNetworkGrant = dmrProtocol["disableNetworkGrant"].as(false); - m_slot1->m_disableNetworkGrant = disableNetworkGrant; - m_slot2->m_disableNetworkGrant = disableNetworkGrant; - bool convNetGrantDemand = dmrProtocol["convNetGrantDemand"].as(false); m_slot1->m_convNetGrantDemand = convNetGrantDemand; m_slot2->m_convNetGrantDemand = convNetGrantDemand; @@ -265,9 +258,6 @@ void Control::setOptions(yaml::Node& conf, bool supervisor, ::lookups::VoiceChDa if (m_supervisor) LogInfoEx(LOG_DMR, "Host is configured to operate as a DMR TSCC, site controller mode."); } - if (disableNetworkGrant) { - LogInfo(" Disable Network Grants: yes"); - } if (defaultNetIdleTalkgroup != 0U) { LogInfo(" Default Network Idle Talkgroup: %u", defaultNetIdleTalkgroup); diff --git a/src/host/dmr/Slot.cpp b/src/host/dmr/Slot.cpp index a9a93d00..e361d698 100644 --- a/src/host/dmr/Slot.cpp +++ b/src/host/dmr/Slot.cpp @@ -152,7 +152,6 @@ Slot::Slot(uint32_t slotNo, uint32_t timeout, uint32_t tgHang, uint32_t queueSiz m_enableTSCC(false), m_dedicatedTSCC(false), m_ignoreAffiliationCheck(false), - m_disableNetworkGrant(false), m_convNetGrantDemand(false), m_legacyGroupReg(false), m_defaultNetIdleTalkgroup(0U), @@ -460,16 +459,6 @@ void Slot::processNetwork(const data::NetData& dmrData) bool unitToUnit = (dmrData.getControl() & network::NET_CTRL_U2U) == network::NET_CTRL_U2U; if (grantDemand) { - if (m_disableNetworkGrant) { - break; - } - - // if we're non-dedicated control, and if we're not in a listening or idle state, ignore any grant - // demands - if (!dedicatedTSCC && (m_rfState != RS_RF_LISTENING || m_netState != RS_NET_IDLE)) { - break; - } - // validate source RID if (!acl::AccessControl::validateSrcId(dmrData.getSrcId())) { break; @@ -497,15 +486,11 @@ void Slot::processNetwork(const data::NetData& dmrData) break; } - // if *this slot* is the TSCC slot, stop processing after this point - if (m_enableTSCC && m_dedicatedTSCC) - { - if (dataType != DataType::CSBK && dataType != DataType::MBC_HEADER && dataType != DataType::MBC_DATA) + if (dataType != DataType::CSBK && dataType != DataType::MBC_HEADER && dataType != DataType::MBC_DATA) + return; + else { + if (m_slotNo != s_dmr->m_tsccSlotNo) return; - else { - if (m_slotNo != s_dmr->m_tsccSlotNo) - return; - } } } diff --git a/src/host/dmr/Slot.h b/src/host/dmr/Slot.h index 5da5e6ec..f84fac4f 100644 --- a/src/host/dmr/Slot.h +++ b/src/host/dmr/Slot.h @@ -494,7 +494,6 @@ namespace dmr bool m_enableTSCC; bool m_dedicatedTSCC; bool m_ignoreAffiliationCheck; - bool m_disableNetworkGrant; bool m_convNetGrantDemand; bool m_legacyGroupReg;