From 74473bb6ad716c7188719d549e7d66f780d2d161 Mon Sep 17 00:00:00 2001 From: Bryan Biedenkapp Date: Fri, 29 May 2026 07:56:29 -0400 Subject: [PATCH] bump default nakFallOver count from 10 to 50 to decrease NAK fallover sensitivity; --- configs/fne-config.example.yml | 2 +- src/fne/HostFNE.cpp | 2 +- src/fne/network/PeerNetwork.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configs/fne-config.example.yml b/configs/fne-config.example.yml index 0c4c1277..03619d0a 100644 --- a/configs/fne-config.example.yml +++ b/configs/fne-config.example.yml @@ -290,7 +290,7 @@ peers: # Amount of NAKs from the master to this peer that will cause this peer to fall over (restart). # (This is only applicable if nakFallOver is true. This is a protection mechanism to prevent a bad network connection # from causing instability in the FNE master.) - nakFallOverCount: 10 + nakFallOverCount: 50 # Flag indicating whether or not packet dumping is enabled. packetDump: false diff --git a/src/fne/HostFNE.cpp b/src/fne/HostFNE.cpp index 115f0f0e..0c6954d6 100644 --- a/src/fne/HostFNE.cpp +++ b/src/fne/HostFNE.cpp @@ -861,7 +861,7 @@ bool HostFNE::createPeerNetworks() std::string location = peerConf["location"].as(); bool nakFallOver = peerConf["nakFallOver"].as(false); - uint32_t nakFallOverCount = peerConf["nakFallOverCount"].as(10U); + uint32_t nakFallOverCount = peerConf["nakFallOverCount"].as(50U); ::LogInfoEx(LOG_HOST, "Peer ID %u Master Address %s Master Port %u Enabled %u Encrypted %u NAK Fall Over %u", id, masterAddress.c_str(), masterPort, enabled, encrypted, nakFallOver); diff --git a/src/fne/network/PeerNetwork.cpp b/src/fne/network/PeerNetwork.cpp index 4b42a827..fde8e86c 100644 --- a/src/fne/network/PeerNetwork.cpp +++ b/src/fne/network/PeerNetwork.cpp @@ -59,7 +59,7 @@ PeerNetwork::PeerNetwork(const std::string& address, uint16_t port, uint16_t loc m_prevSpanningTreeChildren(0U), m_nakFallOver(false), m_nakFallOverCount(0U), - m_nakFallOverCountThreshold(10U) + m_nakFallOverCountThreshold(50U) { assert(!address.empty()); assert(port > 0U);