From 25386ec8f62cb1304ea3b797f1d8a3f7f8073543 Mon Sep 17 00:00:00 2001 From: Bryan Biedenkapp Date: Sat, 28 Mar 2026 12:42:04 -0400 Subject: [PATCH] because the new peerClass system removes the flags from the peer configuration, we will ensure they remain populated for REST API users; --- src/fne/network/TrafficNetwork.cpp | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/src/fne/network/TrafficNetwork.cpp b/src/fne/network/TrafficNetwork.cpp index b2cc57b5..8db7f6c0 100644 --- a/src/fne/network/TrafficNetwork.cpp +++ b/src/fne/network/TrafficNetwork.cpp @@ -1444,7 +1444,13 @@ void TrafficNetwork::taskNetworkRx(NetPacketRequest* req) if (network->m_allowConvSiteAffOverride) { bool convPeer = peerConfig["conventionalPeer"].get(); connection->isConventional(convPeer); + } else { + bool conventionalPeer = false; + peerConfig["conventionalPeer"].set(conventionalPeer); } + } else { + bool conventionalPeer = false; + peerConfig["conventionalPeer"].set(conventionalPeer); } // report peer class in log @@ -1468,6 +1474,19 @@ void TrafficNetwork::taskNetworkRx(NetPacketRequest* req) break; } + // for the purposes of maintaining backward compat with REST API users, + // we will report the peer class via the old externalPeer and sysView boolean + // fields as well (consolePeer doesn't have a legacy field, but that's ok since + // it's only used for console connections which should be new enough to support + // the new peerClass field) + bool externalPeer = connection->peerClass() == PEER_CONN_CLASS_NEIGHBOR; + peerConfig["externalPeer"].set(externalPeer); + bool sysViewPeer = connection->peerClass() == PEER_CONN_CLASS_SYSVIEW; + peerConfig["sysView"].set(sysViewPeer); + bool consolePeer = connection->peerClass() == PEER_CONN_CLASS_CONSOLE; + peerConfig["consolePeer"].set(consolePeer); + connection->config(peerConfig); + // is the peer reporting it is an downstream FNE neighbor peer? /* ** bryanb: don't change externalPeer to neighborPeer -- this will break backward